Title: [238578] trunk/Source/_javascript_Core
Revision
238578
Author
mark....@apple.com
Date
2018-11-27 14:14:56 -0800 (Tue, 27 Nov 2018)

Log Message

[Re-landing] NaNs read from Wasm code needs to be be purified.
https://bugs.webkit.org/show_bug.cgi?id=191056
<rdar://problem/45660341>

Reviewed by Filip Pizlo.

* wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::link):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (238577 => 238578)


--- trunk/Source/_javascript_Core/ChangeLog	2018-11-27 22:12:53 UTC (rev 238577)
+++ trunk/Source/_javascript_Core/ChangeLog	2018-11-27 22:14:56 UTC (rev 238578)
@@ -1,3 +1,14 @@
+2018-11-27  Mark Lam  <mark....@apple.com>
+
+        [Re-landing] NaNs read from Wasm code needs to be be purified.
+        https://bugs.webkit.org/show_bug.cgi?id=191056
+        <rdar://problem/45660341>
+
+        Reviewed by Filip Pizlo.
+
+        * wasm/js/WebAssemblyModuleRecord.cpp:
+        (JSC::WebAssemblyModuleRecord::link):
+
 2018-11-27  Timothy Hatcher  <timo...@apple.com>
 
         Web Inspector: Add support for forcing color scheme appearance in DOM tree.

Modified: trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp (238577 => 238578)


--- trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp	2018-11-27 22:12:53 UTC (rev 238577)
+++ trunk/Source/_javascript_Core/wasm/js/WebAssemblyModuleRecord.cpp	2018-11-27 22:14:56 UTC (rev 238578)
@@ -388,11 +388,11 @@
                 return;
 
             case Wasm::F32:
-                exportedValue = JSValue(m_instance->instance().loadF32Global(exp.kindIndex));
+                exportedValue = jsNumber(purifyNaN(m_instance->instance().loadF32Global(exp.kindIndex)));
                 break;
 
             case Wasm::F64:
-                exportedValue = JSValue(m_instance->instance().loadF64Global(exp.kindIndex));
+                exportedValue = jsNumber(purifyNaN(m_instance->instance().loadF64Global(exp.kindIndex)));
                 break;
 
             default:
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to