Title: [238588] trunk/Source/WebCore
- Revision
- 238588
- Author
- [email protected]
- Date
- 2018-11-27 16:26:09 -0800 (Tue, 27 Nov 2018)
Log Message
Remove kCCNotVerified
https://bugs.webkit.org/show_bug.cgi?id=192034
<rdar://problem/46235863>
Reviewed by Alexey Proskuryakov.
No change of behaviours.
* crypto/CommonCryptoUtilities.h:
* crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
(WebCore::verifyRSASSA_PKCS1_v1_5):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (238587 => 238588)
--- trunk/Source/WebCore/ChangeLog 2018-11-28 00:20:28 UTC (rev 238587)
+++ trunk/Source/WebCore/ChangeLog 2018-11-28 00:26:09 UTC (rev 238588)
@@ -1,3 +1,17 @@
+2018-11-27 Jiewen Tan <[email protected]>
+
+ Remove kCCNotVerified
+ https://bugs.webkit.org/show_bug.cgi?id=192034
+ <rdar://problem/46235863>
+
+ Reviewed by Alexey Proskuryakov.
+
+ No change of behaviours.
+
+ * crypto/CommonCryptoUtilities.h:
+ * crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
+ (WebCore::verifyRSASSA_PKCS1_v1_5):
+
2018-11-27 Simon Fraser <[email protected]>
Avoid triggering compositing updates when only the root layer is composited
Modified: trunk/Source/WebCore/crypto/CommonCryptoUtilities.h (238587 => 238588)
--- trunk/Source/WebCore/crypto/CommonCryptoUtilities.h 2018-11-28 00:20:28 UTC (rev 238587)
+++ trunk/Source/WebCore/crypto/CommonCryptoUtilities.h 2018-11-28 00:26:09 UTC (rev 238588)
@@ -71,10 +71,6 @@
ccRSAPSSPadding = 1005
};
typedef uint32_t CCAsymmetricPadding;
-
-enum {
- kCCNotVerified = -4306
-};
#endif
typedef struct _CCBigNumRef *CCBigNumRef;
Modified: trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp (238587 => 238588)
--- trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp 2018-11-28 00:20:28 UTC (rev 238587)
+++ trunk/Source/WebCore/crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp 2018-11-28 00:26:09 UTC (rev 238588)
@@ -77,7 +77,7 @@
auto status = CCRSACryptorVerify(key, ccPKCS1Padding, digestData.data(), digestData.size(), digestAlgorithm, 0, signature.data(), signature.size());
if (!status)
return true;
- if (status == kCCNotVerified || status == kCCDecodeError) // <rdar://problem/15464982> CCRSACryptorVerify returns kCCDecodeError instead of kCCNotVerified sometimes
+ if (status == kCCDecodeError)
return false;
return Exception { OperationError };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
