Title: [238600] trunk/Source/WebCore
- Revision
- 238600
- Author
- [email protected]
- Date
- 2018-11-27 19:05:16 -0800 (Tue, 27 Nov 2018)
Log Message
Fix the mis-spelled "m_clienstWaitingForAsyncDecoding"
https://bugs.webkit.org/show_bug.cgi?id=192060
Reviewed by Wenson Hsieh.
Fix the mis-spelling of "m_clienstWaitingForAsyncDecoding".
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::didRemoveClient):
(WebCore::CachedImage::isClientWaitingForAsyncDecoding const):
(WebCore::CachedImage::addClientWaitingForAsyncDecoding):
(WebCore::CachedImage::removeAllClientsWaitingForAsyncDecoding):
(WebCore::CachedImage::allClientsRemoved):
(WebCore::CachedImage::clear):
(WebCore::CachedImage::createImage):
(WebCore::CachedImage::imageFrameAvailable):
* loader/cache/CachedImage.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (238599 => 238600)
--- trunk/Source/WebCore/ChangeLog 2018-11-28 02:55:42 UTC (rev 238599)
+++ trunk/Source/WebCore/ChangeLog 2018-11-28 03:05:16 UTC (rev 238600)
@@ -1,3 +1,23 @@
+2018-11-27 Simon Fraser <[email protected]>
+
+ Fix the mis-spelled "m_clienstWaitingForAsyncDecoding"
+ https://bugs.webkit.org/show_bug.cgi?id=192060
+
+ Reviewed by Wenson Hsieh.
+
+ Fix the mis-spelling of "m_clienstWaitingForAsyncDecoding".
+
+ * loader/cache/CachedImage.cpp:
+ (WebCore::CachedImage::didRemoveClient):
+ (WebCore::CachedImage::isClientWaitingForAsyncDecoding const):
+ (WebCore::CachedImage::addClientWaitingForAsyncDecoding):
+ (WebCore::CachedImage::removeAllClientsWaitingForAsyncDecoding):
+ (WebCore::CachedImage::allClientsRemoved):
+ (WebCore::CachedImage::clear):
+ (WebCore::CachedImage::createImage):
+ (WebCore::CachedImage::imageFrameAvailable):
+ * loader/cache/CachedImage.h:
+
2018-11-27 Mark Lam <[email protected]>
ENABLE_FAST_JIT_PERMISSIONS should be false for iosmac.
Modified: trunk/Source/WebCore/loader/cache/CachedImage.cpp (238599 => 238600)
--- trunk/Source/WebCore/loader/cache/CachedImage.cpp 2018-11-28 02:55:42 UTC (rev 238599)
+++ trunk/Source/WebCore/loader/cache/CachedImage.cpp 2018-11-28 03:05:16 UTC (rev 238600)
@@ -130,7 +130,7 @@
ASSERT(client.resourceClientType() == CachedImageClient::expectedType());
m_pendingContainerContextRequests.remove(&static_cast<CachedImageClient&>(client));
- m_clienstWaitingForAsyncDecoding.remove(&static_cast<CachedImageClient&>(client));
+ m_clientsWaitingForAsyncDecoding.remove(&static_cast<CachedImageClient&>(client));
if (m_svgImageCache)
m_svgImageCache->removeClientFromCache(&static_cast<CachedImageClient&>(client));
@@ -142,36 +142,36 @@
bool CachedImage::isClientWaitingForAsyncDecoding(CachedImageClient& client) const
{
- return m_clienstWaitingForAsyncDecoding.contains(&client);
+ return m_clientsWaitingForAsyncDecoding.contains(&client);
}
void CachedImage::addClientWaitingForAsyncDecoding(CachedImageClient& client)
{
ASSERT(client.resourceClientType() == CachedImageClient::expectedType());
- if (m_clienstWaitingForAsyncDecoding.contains(&client))
+ if (m_clientsWaitingForAsyncDecoding.contains(&client))
return;
if (!m_clients.contains(&client)) {
// If the <html> element does not have its own background specified, painting the root box
// renderer uses the style of the <body> element, see RenderView::rendererForRootBackground().
// In this case, the client we are asked to add is the root box renderer. Since we can't add
- // a client to m_clienstWaitingForAsyncDecoding unless it is one of the m_clients, we are going
+ // a client to m_clientsWaitingForAsyncDecoding unless it is one of the m_clients, we are going
// to cancel the repaint optimization we do in CachedImage::imageFrameAvailable() by adding
- // all the m_clients to m_clienstWaitingForAsyncDecoding.
+ // all the m_clients to m_clientsWaitingForAsyncDecoding.
CachedResourceClientWalker<CachedImageClient> walker(m_clients);
while (auto* client = walker.next())
- m_clienstWaitingForAsyncDecoding.add(client);
+ m_clientsWaitingForAsyncDecoding.add(client);
} else
- m_clienstWaitingForAsyncDecoding.add(&client);
+ m_clientsWaitingForAsyncDecoding.add(&client);
}
void CachedImage::removeAllClientsWaitingForAsyncDecoding()
{
- if (m_clienstWaitingForAsyncDecoding.isEmpty() || !hasImage() || !is<BitmapImage>(image()))
+ if (m_clientsWaitingForAsyncDecoding.isEmpty() || !hasImage() || !is<BitmapImage>(image()))
return;
downcast<BitmapImage>(image())->stopAsyncDecodingQueue();
- for (auto* client : m_clienstWaitingForAsyncDecoding)
+ for (auto* client : m_clientsWaitingForAsyncDecoding)
client->imageChanged(this);
- m_clienstWaitingForAsyncDecoding.clear();
+ m_clientsWaitingForAsyncDecoding.clear();
}
void CachedImage::switchClientsToRevalidatedResource()
@@ -196,7 +196,7 @@
void CachedImage::allClientsRemoved()
{
m_pendingContainerContextRequests.clear();
- m_clienstWaitingForAsyncDecoding.clear();
+ m_clientsWaitingForAsyncDecoding.clear();
if (m_image && !errorOccurred())
m_image->resetAnimation();
}
@@ -338,7 +338,7 @@
destroyDecodedData();
clearImage();
m_pendingContainerContextRequests.clear();
- m_clienstWaitingForAsyncDecoding.clear();
+ m_clientsWaitingForAsyncDecoding.clear();
setEncodedSize(0);
}
@@ -362,7 +362,7 @@
setContainerContextForClient(*request.key, request.value.containerSize, request.value.containerZoom, request.value.imageURL);
}
m_pendingContainerContextRequests.clear();
- m_clienstWaitingForAsyncDecoding.clear();
+ m_clientsWaitingForAsyncDecoding.clear();
}
}
@@ -627,7 +627,7 @@
while (CachedImageClient* client = clientWalker.next()) {
// All the clients of animated images have to be notified. The new frame has to be drawn in all of them.
- if (animatingState == ImageAnimatingState::No && !m_clienstWaitingForAsyncDecoding.contains(client))
+ if (animatingState == ImageAnimatingState::No && !m_clientsWaitingForAsyncDecoding.contains(client))
continue;
if (client->imageFrameAvailable(*this, animatingState, changeRect) == VisibleInViewportState::Yes)
visibleState = VisibleInViewportState::Yes;
@@ -637,7 +637,7 @@
m_image->stopAnimation();
if (decodingStatus != DecodingStatus::Partial)
- m_clienstWaitingForAsyncDecoding.clear();
+ m_clientsWaitingForAsyncDecoding.clear();
}
void CachedImage::changedInRect(const Image& image, const IntRect* rect)
Modified: trunk/Source/WebCore/loader/cache/CachedImage.h (238599 => 238600)
--- trunk/Source/WebCore/loader/cache/CachedImage.h 2018-11-28 02:55:42 UTC (rev 238599)
+++ trunk/Source/WebCore/loader/cache/CachedImage.h 2018-11-28 03:05:16 UTC (rev 238600)
@@ -172,7 +172,7 @@
using ContainerContextRequests = HashMap<const CachedImageClient*, ContainerContext>;
ContainerContextRequests m_pendingContainerContextRequests;
- HashSet<CachedImageClient*> m_clienstWaitingForAsyncDecoding;
+ HashSet<CachedImageClient*> m_clientsWaitingForAsyncDecoding;
RefPtr<CachedImageObserver> m_imageObserver;
RefPtr<Image> m_image;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
