Title: [238605] trunk/Source/WebCore
- Revision
- 238605
- Author
- [email protected]
- Date
- 2018-11-28 04:40:08 -0800 (Wed, 28 Nov 2018)
Log Message
[GStreamer][WebRTC] Do not run device monitor for device type we do not handle
https://bugs.webkit.org/show_bug.cgi?id=191904
This is useless work and it throws warning about use GstDeviceMonitor without filters.
Patch by Thibault Saunier <[email protected]> on 2018-11-28
Reviewed by Philippe Normand.
* platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:
(WebCore::GStreamerCaptureDeviceManager::refreshCaptureDevices):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (238604 => 238605)
--- trunk/Source/WebCore/ChangeLog 2018-11-28 08:28:12 UTC (rev 238604)
+++ trunk/Source/WebCore/ChangeLog 2018-11-28 12:40:08 UTC (rev 238605)
@@ -1,3 +1,15 @@
+2018-11-28 Thibault Saunier <[email protected]>
+
+ [GStreamer][WebRTC] Do not run device monitor for device type we do not handle
+ https://bugs.webkit.org/show_bug.cgi?id=191904
+
+ This is useless work and it throws warning about use GstDeviceMonitor without filters.
+
+ Reviewed by Philippe Normand.
+
+ * platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp:
+ (WebCore::GStreamerCaptureDeviceManager::refreshCaptureDevices):
+
2018-11-27 Rob Buis <[email protected]>
Block more ports (427, 548, 6697)
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp (238604 => 238605)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp 2018-11-28 08:28:12 UTC (rev 238604)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.cpp 2018-11-28 12:40:08 UTC (rev 238605)
@@ -108,10 +108,11 @@
} else if (type == CaptureDevice::DeviceType::Microphone) {
GRefPtr<GstCaps> caps = adoptGRef(gst_caps_new_empty_simple("audio/x-raw"));
gst_device_monitor_add_filter(m_deviceMonitor.get(), "Audio/Source", caps.get());
- }
- // FIXME: Add monitor for added/removed messages on the bus.
+ } else
+ return;
}
+ // FIXME: Add monitor for added/removed messages on the bus.
if (!gst_device_monitor_start(m_deviceMonitor.get())) {
GST_WARNING_OBJECT(m_deviceMonitor.get(), "Could not start device monitor");
m_deviceMonitor = nullptr;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
