Title: [238618] trunk/Tools
- Revision
- 238618
- Author
- [email protected]
- Date
- 2018-11-28 09:52:07 -0800 (Wed, 28 Nov 2018)
Log Message
Fix webkitbot hi command.
https://bugs.webkit.org/show_bug.cgi?id=192080
Reviewed by Alexey Proskuryakov.
* Scripts/webkitpy/tool/bot/irc_command.py:
(Hi.execute):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (238617 => 238618)
--- trunk/Tools/ChangeLog 2018-11-28 17:51:49 UTC (rev 238617)
+++ trunk/Tools/ChangeLog 2018-11-28 17:52:07 UTC (rev 238618)
@@ -1,3 +1,13 @@
+2018-11-28 Lucas Forschler <[email protected]>
+
+ Fix webkitbot hi command.
+ https://bugs.webkit.org/show_bug.cgi?id=192080
+
+ Reviewed by Alexey Proskuryakov.
+
+ * Scripts/webkitpy/tool/bot/irc_command.py:
+ (Hi.execute):
+
2018-11-28 Zalan Bujtas <[email protected]>
[LFC][Quirk] Use non-collapsed vertical margin values when the container is stretched to the size of the ICB.
Modified: trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py (238617 => 238618)
--- trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2018-11-28 17:51:49 UTC (rev 238617)
+++ trunk/Tools/Scripts/webkitpy/tool/bot/irc_command.py 2018-11-28 17:52:07 UTC (rev 238618)
@@ -117,8 +117,9 @@
def execute(self, nick, args, tool, sheriff):
if len(args) and re.match(sheriff.name() + r'_*\s*!\s*', ' '.join(args)):
return "%s: hi %s!" % (nick, nick)
- if sheriff.name() == 'WKR': # For some unknown reason, WKR can't use tool.bugs.quips().
- return "You're doing it wrong"
+ bypass_quips = ['WKR', 'webkitbot']
+ if sheriff.name() in bypass_quips: # For some unknown reason, WKR/webkitbot can't use tool.bugs.quips().
+ return "%s: hi %s!" % (nick, nick)
quips = tool.bugs.quips()
quips.append('"Only you can prevent forest fires." -- Smokey the Bear')
return random.choice(quips)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes