Title: [238641] trunk/Tools
- Revision
- 238641
- Author
- [email protected]
- Date
- 2018-11-28 14:12:22 -0800 (Wed, 28 Nov 2018)
Log Message
Fix iOS API test after r238585
https://bugs.webkit.org/show_bug.cgi?id=192022
* TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
(TEST):
On iOS, a safe browsing warning over a WKWebView with frame of {0, 0, 0, 0} has a size of {0, 0}, which is fine.
The test was added to catch a bug on Mac platforms, so testing it only on Mac will catch any regression.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (238640 => 238641)
--- trunk/Tools/ChangeLog 2018-11-28 22:11:37 UTC (rev 238640)
+++ trunk/Tools/ChangeLog 2018-11-28 22:12:22 UTC (rev 238641)
@@ -1,3 +1,13 @@
+2018-11-28 Alex Christensen <[email protected]>
+
+ Fix iOS API test after r238585
+ https://bugs.webkit.org/show_bug.cgi?id=192022
+
+ * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
+ (TEST):
+ On iOS, a safe browsing warning over a WKWebView with frame of {0, 0, 0, 0} has a size of {0, 0}, which is fine.
+ The test was added to catch a bug on Mac platforms, so testing it only on Mac will catch any regression.
+
2018-11-28 Aakash Jain <[email protected]>
[ews-app] Configure python logging
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm (238640 => 238641)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm 2018-11-28 22:11:37 UTC (rev 238640)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm 2018-11-28 22:12:22 UTC (rev 238641)
@@ -212,7 +212,9 @@
auto webView = safeBrowsingView();
auto warning = [webView _safeBrowsingWarning];
EXPECT_EQ(warning.subviews.count, 1ull);
+#if PLATFORM(MAC)
EXPECT_GT(warning.subviews.firstObject.subviews[2].frame.size.height, 0);
+#endif
checkTitleAndClick(warning.subviews.firstObject.subviews[4], "Show Details");
EXPECT_EQ(warning.subviews.count, 2ull);
EXPECT_FALSE(committedNavigation);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
