Title: [238658] trunk/Source/WebKit
- Revision
- 238658
- Author
- simon.fra...@apple.com
- Date
- 2018-11-28 19:54:32 -0800 (Wed, 28 Nov 2018)
Log Message
REGRESSION (r234980): Crash in -[WKWebView _restorePageStateToUnobscuredCenter:scale:]
https://bugs.webkit.org/show_bug.cgi?id=192127
rdar://problem/44194179
Reviewed by Tim Horton.
_restorePageStateToUnobscuredCenter: could receive an Optional<FloatRect> from the
web process, and unconditionally called .value() even though it may not be engaged.
No repro steps known, so no testcase.
* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (238657 => 238658)
--- trunk/Source/WebKit/ChangeLog 2018-11-29 02:55:59 UTC (rev 238657)
+++ trunk/Source/WebKit/ChangeLog 2018-11-29 03:54:32 UTC (rev 238658)
@@ -1,3 +1,19 @@
+2018-11-28 Simon Fraser <simon.fra...@apple.com>
+
+ REGRESSION (r234980): Crash in -[WKWebView _restorePageStateToUnobscuredCenter:scale:]
+ https://bugs.webkit.org/show_bug.cgi?id=192127
+ rdar://problem/44194179
+
+ Reviewed by Tim Horton.
+
+ _restorePageStateToUnobscuredCenter: could receive an Optional<FloatRect> from the
+ web process, and unconditionally called .value() even though it may not be engaged.
+
+ No repro steps known, so no testcase.
+
+ * UIProcess/API/Cocoa/WKWebView.mm:
+ (-[WKWebView _restorePageStateToUnobscuredCenter:scale:]):
+
2018-11-28 Commit Queue <commit-qu...@webkit.org>
Unreviewed, rolling out r238653 and r238656.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm (238657 => 238658)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-11-29 02:55:59 UTC (rev 238657)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm 2018-11-29 03:54:32 UTC (rev 238658)
@@ -2039,7 +2039,7 @@
return;
_firstTransactionIDAfterPageRestore = downcast<WebKit::RemoteLayerTreeDrawingAreaProxy>(*_page->drawingArea()).nextLayerTreeTransactionID();
- _unobscuredCenterToRestore = center.value();
+ _unobscuredCenterToRestore = center;
_scaleToRestore = scale;
}
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
