[webkit-changes] [101852] trunk

Fri, 02 Dec 2011 14:17:35 -0800

Title: [101852] trunk
Revision
101852
Author
[email protected]
Date
2011-12-02 14:17:27 -0800 (Fri, 02 Dec 2011)

Log Message

Unreviewed, rolling out r101337.
http://trac.webkit.org/changeset/101337
https://bugs.webkit.org/show_bug.cgi?id=73189

It's a wrong way to fix the problem

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::popupOpened):

LayoutTests:

* fast/forms/select-popup-crash-expected.txt: Removed.
* fast/forms/select-popup-crash.html: Removed.

Modified Paths

Removed Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (101851 => 101852)


--- trunk/LayoutTests/ChangeLog	2011-12-02 22:07:11 UTC (rev 101851)
+++ trunk/LayoutTests/ChangeLog	2011-12-02 22:17:27 UTC (rev 101852)
@@ -1,3 +1,14 @@
+2011-12-02  Kent Tamura  <[email protected]>
+
+        Unreviewed, rolling out r101337.
+        http://trac.webkit.org/changeset/101337
+        https://bugs.webkit.org/show_bug.cgi?id=73189
+
+        It's a wrong way to fix the problem
+
+        * fast/forms/select-popup-crash-expected.txt: Removed.
+        * fast/forms/select-popup-crash.html: Removed.
+
 2011-12-02  Kausalya Madhusudhanan  <[email protected]>
 
         Added helper method to identify whether the page has custom page size style.

Deleted: trunk/LayoutTests/fast/forms/select-popup-crash-expected.txt (101851 => 101852)


--- trunk/LayoutTests/fast/forms/select-popup-crash-expected.txt	2011-12-02 22:07:11 UTC (rev 101851)
+++ trunk/LayoutTests/fast/forms/select-popup-crash-expected.txt	2011-12-02 22:17:27 UTC (rev 101852)
@@ -1,5 +0,0 @@
-<select> test for opening two popup menus.
-
-PASS if the test didn't crash.
-
-

Deleted: trunk/LayoutTests/fast/forms/select-popup-crash.html (101851 => 101852)


--- trunk/LayoutTests/fast/forms/select-popup-crash.html	2011-12-02 22:07:11 UTC (rev 101851)
+++ trunk/LayoutTests/fast/forms/select-popup-crash.html	2011-12-02 22:17:27 UTC (rev 101852)
@@ -1,53 +0,0 @@
-<!DOCTYPE HTML>
-<html>
-<head>
-</head>
-<body>
-<p id="description">&lt;select> test for opening two popup menus.</p>
-<div id="console"></div>
-<p id="debug">PASS if the test didn't crash.</p>
-<script>
-    if (window.layoutTestController)
-        layoutTestController.dumpAsText();
-
-    var parent = document.createElement('div');
-    parent.innerHTML = '<select id="sl1">'
-        + '<option>one</option>'
-        + '<option>two</option>'
-        + '<option>three</option>'
-        + '<option>four</option>'
-        + '<option>five</option>'
-        + '<option>six</option>'
-        + '<option>seven</option>'
-        + '<option>eight</option>'
-        + '<option>nine</option>'
-        + '<option>ten</option>'
-        + '<option>eleven</option>'
-        + '<option>twelve</option>'
-        + '<option>thirteen</option>'
-        + '<option>fourteen</option>'
-        + '<option>fifteen</option>'
-        + '<option>sixteen</option>'
-        + '<option>seventeen</option>'
-        + '</select>'
-        + '<select id="sl2">'
-        + '<option>one</option>'
-        + '<option>two</option>'
-        + '<option>three</option>'
-        + '</select>';
-    document.body.appendChild(parent);
-
-    function mouseDownOnSelect(selId)
-    {
-        var sl = document.getElementById(selId);
-        var event = document.createEvent("MouseEvent");
-        event.initMouseEvent("mousedown", true, true, document.defaultView, 1, sl.offsetLeft, sl.offsetTop, sl.offsetLeft, sl.offsetTop, false, false, false, false, 0, document);
-        sl.dispatchEvent(event);
-    }
-
-    mouseDownOnSelect("sl1");
-    mouseDownOnSelect("sl2");
-
-</script>
-</body>
-</html>

Modified: trunk/Source/WebKit/chromium/ChangeLog (101851 => 101852)


--- trunk/Source/WebKit/chromium/ChangeLog	2011-12-02 22:07:11 UTC (rev 101851)
+++ trunk/Source/WebKit/chromium/ChangeLog	2011-12-02 22:17:27 UTC (rev 101852)
@@ -1,3 +1,14 @@
+2011-12-02  Kent Tamura  <[email protected]>
+
+        Unreviewed, rolling out r101337.
+        http://trac.webkit.org/changeset/101337
+        https://bugs.webkit.org/show_bug.cgi?id=73189
+
+        It's a wrong way to fix the problem
+
+        * src/WebViewImpl.cpp:
+        (WebKit::WebViewImpl::popupOpened):
+
 2011-12-02  Kausalya Madhusudhanan  <[email protected]>
 
         Added helper method to identify whether the page has custom page size style.

Modified: trunk/Source/WebKit/chromium/src/WebViewImpl.cpp (101851 => 101852)


--- trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-12-02 22:07:11 UTC (rev 101851)
+++ trunk/Source/WebKit/chromium/src/WebViewImpl.cpp	2011-12-02 22:17:27 UTC (rev 101852)
@@ -968,8 +968,8 @@
 void  WebViewImpl::popupOpened(WebCore::PopupContainer* popupContainer)
 {
     if (popupContainer->popupType() == WebCore::PopupContainer::Select) {
-        if (!m_selectPopup)
-            m_selectPopup = popupContainer;
+        ASSERT(!m_selectPopup);
+        m_selectPopup = popupContainer;
     }
 }
 

_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to