Title: [238746] trunk/Source/WebKit
- Revision
- 238746
- Author
- [email protected]
- Date
- 2018-11-30 11:37:44 -0800 (Fri, 30 Nov 2018)
Log Message
Remove unused WebProcessCreationParameters.uiProcessCookieStorageIdentifier
https://bugs.webkit.org/show_bug.cgi?id=192157
Reviewed by Chris Dumez.
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeWebProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (238745 => 238746)
--- trunk/Source/WebKit/ChangeLog 2018-11-30 19:37:04 UTC (rev 238745)
+++ trunk/Source/WebKit/ChangeLog 2018-11-30 19:37:44 UTC (rev 238746)
@@ -1,5 +1,19 @@
2018-11-30 Alex Christensen <[email protected]>
+ Remove unused WebProcessCreationParameters.uiProcessCookieStorageIdentifier
+ https://bugs.webkit.org/show_bug.cgi?id=192157
+
+ Reviewed by Chris Dumez.
+
+ * Shared/WebProcessCreationParameters.cpp:
+ (WebKit::WebProcessCreationParameters::encode const):
+ (WebKit::WebProcessCreationParameters::decode):
+ * Shared/WebProcessCreationParameters.h:
+ * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+ (WebKit::WebProcessPool::platformInitializeWebProcess):
+
+2018-11-30 Alex Christensen <[email protected]>
+
Remove privateBrowsingEnabled from NetworkProcessCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=192156
Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp (238745 => 238746)
--- trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2018-11-30 19:37:04 UTC (rev 238745)
+++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.cpp 2018-11-30 19:37:44 UTC (rev 238746)
@@ -57,9 +57,6 @@
encoder << mediaCacheDirectoryExtensionHandle;
encoder << _javascript_ConfigurationDirectory;
encoder << _javascript_ConfigurationDirectoryExtensionHandle;
-#if PLATFORM(MAC)
- encoder << uiProcessCookieStorageIdentifier;
-#endif
#if PLATFORM(IOS_FAMILY)
encoder << cookieStorageDirectoryExtensionHandle;
encoder << containerCachesDirectoryExtensionHandle;
@@ -220,10 +217,6 @@
return false;
parameters._javascript_ConfigurationDirectoryExtensionHandle = WTFMove(*_javascript_ConfigurationDirectoryExtensionHandle);
-#if PLATFORM(MAC)
- if (!decoder.decode(parameters.uiProcessCookieStorageIdentifier))
- return false;
-#endif
#if PLATFORM(IOS_FAMILY)
std::optional<SandboxExtension::Handle> cookieStorageDirectoryExtensionHandle;
Modified: trunk/Source/WebKit/Shared/WebProcessCreationParameters.h (238745 => 238746)
--- trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2018-11-30 19:37:04 UTC (rev 238745)
+++ trunk/Source/WebKit/Shared/WebProcessCreationParameters.h 2018-11-30 19:37:44 UTC (rev 238746)
@@ -84,9 +84,6 @@
SandboxExtension::Handle mediaCacheDirectoryExtensionHandle;
String _javascript_ConfigurationDirectory;
SandboxExtension::Handle _javascript_ConfigurationDirectoryExtensionHandle;
-#if PLATFORM(MAC)
- Vector<uint8_t> uiProcessCookieStorageIdentifier;
-#endif
#if PLATFORM(IOS_FAMILY)
SandboxExtension::Handle cookieStorageDirectoryExtensionHandle;
SandboxExtension::Handle containerCachesDirectoryExtensionHandle;
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (238745 => 238746)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2018-11-30 19:37:04 UTC (rev 238745)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm 2018-11-30 19:37:44 UTC (rev 238746)
@@ -220,11 +220,6 @@
}
parameters.networkATSContext = adoptCF(_CFNetworkCopyATSContext());
-#if PLATFORM(MAC)
- ASSERT(parameters.uiProcessCookieStorageIdentifier.isEmpty());
- ASSERT(hasProcessPrivilege(ProcessPrivilege::CanAccessRawCookies));
- parameters.uiProcessCookieStorageIdentifier = identifyingDataFromCookieStorage([[NSHTTPCookieStorage sharedHTTPCookieStorage] _cookieStorage]);
-#endif
#if ENABLE(MEDIA_STREAM)
// Allow microphone access if either preference is set because WebRTC requires microphone access.
bool mediaDevicesEnabled = m_defaultPageGroup->preferences().mediaDevicesEnabled();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
