Title: [238752] trunk/Source/WebInspectorUI
- Revision
- 238752
- Author
- [email protected]
- Date
- 2018-11-30 13:27:54 -0800 (Fri, 30 Nov 2018)
Log Message
Web Inspector: Settings: reload button needs horizontal spacing
https://bugs.webkit.org/show_bug.cgi?id=192231
<rdar://problem/46274363>
Reviewed by Matt Baker.
* UserInterface/Views/SettingsTabContentView.css:
(.content-view.settings > .settings-view > .container button):
(.content-view.settings > .settings-view > .container > .title):
(.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
(body[dir=ltr] .content-view.settings > .settings-view > .container > .title): Deleted.
(body[dir=rtl] .content-view.settings > .settings-view > .container > .title): Deleted.
(body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
(body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
Drive-by: replace `dir=*` attribute rules with `-webkit-margin-*` properties.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238751 => 238752)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-11-30 21:18:13 UTC (rev 238751)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-11-30 21:27:54 UTC (rev 238752)
@@ -1,3 +1,21 @@
+2018-11-30 Devin Rousso <[email protected]>
+
+ Web Inspector: Settings: reload button needs horizontal spacing
+ https://bugs.webkit.org/show_bug.cgi?id=192231
+ <rdar://problem/46274363>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/SettingsTabContentView.css:
+ (.content-view.settings > .settings-view > .container button):
+ (.content-view.settings > .settings-view > .container > .title):
+ (.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]):
+ (body[dir=ltr] .content-view.settings > .settings-view > .container > .title): Deleted.
+ (body[dir=rtl] .content-view.settings > .settings-view > .container > .title): Deleted.
+ (body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
+ (body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"]): Deleted.
+ Drive-by: replace `dir=*` attribute rules with `-webkit-margin-*` properties.
+
2018-11-30 Joseph Pecoraro <[email protected]>
Web Inspector: Uncaught Exception opening Web Inspector to Debugger Tab
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css (238751 => 238752)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css 2018-11-30 21:18:13 UTC (rev 238751)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css 2018-11-30 21:27:54 UTC (rev 238752)
@@ -69,25 +69,17 @@
}
.content-view.settings > .settings-view > .container button {
+ -webkit-margin-end: 4px;
font-size: inherit;
}
.content-view.settings > .settings-view > .container > .title {
+ width: 50%;
margin-top: 2px;
- width: 50%;
+ -webkit-margin-end: 6px;
text-align: end;
-
- --setting-name-margin-end: 6px;
}
-body[dir=ltr] .content-view.settings > .settings-view > .container > .title {
- margin-right: var(--setting-name-margin-end);
-}
-
-body[dir=rtl] .content-view.settings > .settings-view > .container > .title {
- margin-left: var(--setting-name-margin-end);
-}
-
.content-view.settings > .settings-view > .container > .editor-group {
display: flex;
flex-direction: column;
@@ -98,20 +90,11 @@
}
.content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] {
+ -webkit-margin-end: 4px;
/* Vertically align <select> with the group title text. */
font-size: 16px;
-
- --settings-input-checkbox-margin-end: 4px;
}
-body[dir=ltr] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] {
- margin-right: var(--settings-input-checkbox-margin-end);
-}
-
-body[dir=rtl] .content-view.settings > .settings-view > .container > .editor-group > .editor input[type="checkbox"] {
- margin-left: var(--settings-input-checkbox-margin-end);
-}
-
.content-view.settings > .settings-view > .container > .editor-group > .editor select {
/*
To set the font-size of <select> to be exactly 13px, it needs to be set to 16px.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
