Title: [238763] trunk/Tools
- Revision
- 238763
- Author
- [email protected]
- Date
- 2018-11-30 16:26:01 -0800 (Fri, 30 Nov 2018)
Log Message
REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
https://bugs.webkit.org/show_bug.cgi?id=192257
<rdar://problem/46384671>
Reviewed by Stephanie Lewis.
Follow-up fix for r238749.
* Scripts/webkitpy/api_tests/manager.py:
(Manager._initialize_devices): Use DEFAULT_DEVICE_TYPE instead of DEFAULT_DEVICE_CLASS.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (238762 => 238763)
--- trunk/Tools/ChangeLog 2018-12-01 00:15:16 UTC (rev 238762)
+++ trunk/Tools/ChangeLog 2018-12-01 00:26:01 UTC (rev 238763)
@@ -1,3 +1,16 @@
+2018-11-30 Jonathan Bedard <[email protected]>
+
+ REGRESSION (r238749): run-api-tests dies with AttributeError: 'IOSSimulatorPort' object has no attribute 'DEFAULT_DEVICE_CLASS'
+ https://bugs.webkit.org/show_bug.cgi?id=192257
+ <rdar://problem/46384671>
+
+ Reviewed by Stephanie Lewis.
+
+ Follow-up fix for r238749.
+
+ * Scripts/webkitpy/api_tests/manager.py:
+ (Manager._initialize_devices): Use DEFAULT_DEVICE_TYPE instead of DEFAULT_DEVICE_CLASS.
+
2018-11-30 Chris Dumez <[email protected]>
[PSON] We are sometimes swapping processes even though there is an opened window with an opener link to us
Modified: trunk/Tools/Scripts/webkitpy/api_tests/manager.py (238762 => 238763)
--- trunk/Tools/Scripts/webkitpy/api_tests/manager.py 2018-12-01 00:15:16 UTC (rev 238762)
+++ trunk/Tools/Scripts/webkitpy/api_tests/manager.py 2018-12-01 00:26:01 UTC (rev 238763)
@@ -26,7 +26,6 @@
from webkitpy.api_tests.runner import Runner
from webkitpy.common.system.executive import ScriptError
-from webkitpy.xcode.device_type import DeviceType
from webkitpy.xcode.simulated_device import DeviceRequest, SimulatedDeviceManager
_log = logging.getLogger(__name__)
@@ -129,7 +128,7 @@
def _initialize_devices(self):
if 'simulator' in self._port.port_name:
- SimulatedDeviceManager.initialize_devices(DeviceRequest(DeviceType.from_string(self._port.DEFAULT_DEVICE_CLASS), allow_incomplete_match=True), self.host, simulator_ui=False)
+ SimulatedDeviceManager.initialize_devices(DeviceRequest(self._port.DEFAULT_DEVICE_TYPE, allow_incomplete_match=True), self.host, simulator_ui=False)
elif 'device' in self._port.port_name:
raise RuntimeError('Running api tests on {} is not supported'.format(self._port.port_name))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
