Title: [238784] trunk/Tools
- Revision
- 238784
- Author
- [email protected]
- Date
- 2018-12-01 13:09:08 -0800 (Sat, 01 Dec 2018)
Log Message
Unreviewed, rolling out r238764.
Breaks existing layout tests
Reverted changeset:
"webkitpy: Support unicode in MeteredStream"
https://bugs.webkit.org/show_bug.cgi?id=192260
https://trac.webkit.org/changeset/238764
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (238783 => 238784)
--- trunk/Tools/ChangeLog 2018-12-01 20:08:22 UTC (rev 238783)
+++ trunk/Tools/ChangeLog 2018-12-01 21:09:08 UTC (rev 238784)
@@ -1,3 +1,15 @@
+2018-12-01 Jonathan Bedard <[email protected]>
+
+ Unreviewed, rolling out r238764.
+
+ Breaks existing layout tests
+
+ Reverted changeset:
+
+ "webkitpy: Support unicode in MeteredStream"
+ https://bugs.webkit.org/show_bug.cgi?id=192260
+ https://trac.webkit.org/changeset/238764
+
2018-12-01 Yusuke Suzuki <[email protected]>
Move URL tests from TestWebKitAPI to TestWTF
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py (238783 => 238784)
--- trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py 2018-12-01 20:08:22 UTC (rev 238783)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream.py 2018-12-01 21:09:08 UTC (rev 238784)
@@ -105,9 +105,9 @@
timestamp_string = '%02d:%02d:%02d.%03d %d ' % (now_tuple.tm_hour, now_tuple.tm_min, now_tuple.tm_sec, int((now * 1000) % 1000), pid)
if self._isatty and not self._verbose:
- msg = u'{}{}'.format(timestamp_string, txt)
+ msg = '{}{}'.format(timestamp_string, txt)
else:
- msg = u'{}{}'.format(timestamp_string, self._ensure_newline(txt))
+ msg = '{}{}'.format(timestamp_string, self._ensure_newline(txt))
self._stream.write(msg)
Modified: trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py (238783 => 238784)
--- trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py 2018-12-01 20:08:22 UTC (rev 238783)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py 2018-12-01 21:09:08 UTC (rev 238784)
@@ -108,11 +108,7 @@
self.logger.info('foo %s %d', 'bar', 2)
self.assertEqual(self.buflist, ['foo bar 2\n'])
- def test_unicode(self):
- self.logger.info(u'\u2713')
- self.assertEqual(self.buflist[-1][-2:], u'\u2713\n')
-
class TtyTest(RegularTest):
verbose = False
isatty = True
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
