Title: [238842] trunk/Source/WebInspectorUI
- Revision
- 238842
- Author
- [email protected]
- Date
- 2018-12-03 20:06:55 -0800 (Mon, 03 Dec 2018)
Log Message
Web Inspector: Audit: sidebar briefly shows "No Filter Results" before populating default audits
https://bugs.webkit.org/show_bug.cgi?id=192341
<rdar://problem/46436550>
Reviewed by Matt Baker.
* UserInterface/Views/AuditNavigationSidebarPanel.js:
(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype._addTest):
(WI.AuditNavigationSidebarPanel.prototype._addResult):
(WI.AuditNavigationSidebarPanel.prototype.applyFiltersToTreeElement): Deleted.
Delay the construction of the "Results" folder until it's needed, since adding a hidden
`WI.TreeElement` will cause the placeholder to appear.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238841 => 238842)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-04 04:06:31 UTC (rev 238841)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-04 04:06:55 UTC (rev 238842)
@@ -1,5 +1,21 @@
2018-12-03 Devin Rousso <[email protected]>
+ Web Inspector: Audit: sidebar briefly shows "No Filter Results" before populating default audits
+ https://bugs.webkit.org/show_bug.cgi?id=192341
+ <rdar://problem/46436550>
+
+ Reviewed by Matt Baker.
+
+ * UserInterface/Views/AuditNavigationSidebarPanel.js:
+ (WI.AuditNavigationSidebarPanel.prototype.initialLayout):
+ (WI.AuditNavigationSidebarPanel.prototype._addTest):
+ (WI.AuditNavigationSidebarPanel.prototype._addResult):
+ (WI.AuditNavigationSidebarPanel.prototype.applyFiltersToTreeElement): Deleted.
+ Delay the construction of the "Results" folder until it's needed, since adding a hidden
+ `WI.TreeElement` will cause the placeholder to appear.
+
+2018-12-03 Devin Rousso <[email protected]>
+
Web Inspector: Audit: navigating while tests are running should stop and clear all results
https://bugs.webkit.org/show_bug.cgi?id=192317
<rdar://problem/46435222>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js (238841 => 238842)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js 2018-12-04 04:06:31 UTC (rev 238841)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditNavigationSidebarPanel.js 2018-12-04 04:06:55 UTC (rev 238842)
@@ -57,11 +57,6 @@
this.contentTreeOutline.allowsRepeatSelection = false;
- this._resultsFolderTreeElement = new WI.FolderTreeElement(WI.UIString("Results"));
- this.contentTreeOutline.appendChild(this._resultsFolderTreeElement);
- this._resultsFolderTreeElement.hidden = true;
- this._resultsFolderTreeElement.expand();
-
let navigationBar = new WI.NavigationBar;
this._startStopButtonNavigationItem = new WI.ToggleButtonNavigationItem("audit-start-stop", WI.UIString("Start"), WI.UIString("Stop"), "Images/AuditStart.svg", "Images/AuditStop.svg", 13, 13);
@@ -110,14 +105,6 @@
this._updateNoAuditsPlaceholder();
}
- applyFiltersToTreeElement(treeElement)
- {
- super.applyFiltersToTreeElement(treeElement);
-
- if (treeElement === this._resultsFolderTreeElement && !WI.auditManager.results.length)
- this._resultsFolderTreeElement.hidden = true;
- }
-
// Private
_addTest(test)
@@ -126,9 +113,13 @@
this._updateStartStopButtonNavigationItemState();
- this.contentTreeOutline.insertChild(new WI.AuditTreeElement(test), this.contentTreeOutline.children.indexOf(this._resultsFolderTreeElement));
+ let treeElement = new WI.AuditTreeElement(test);
- this._resultsFolderTreeElement.hidden = !this._resultsFolderTreeElement.children.length;
+ if (this._resultsFolderTreeElement) {
+ this.contentTreeOutline.insertChild(treeElement, this.contentTreeOutline.children.indexOf(this._resultsFolderTreeElement));
+ this._resultsFolderTreeElement.hidden = !this._resultsFolderTreeElement.children.length;
+ } else
+ this.contentTreeOutline.appendChild(treeElement);
this.hideEmptyContentPlaceholder();
}
@@ -139,8 +130,13 @@
this._updateStartStopButtonNavigationItemState();
- this._resultsFolderTreeElement.hidden = false;
+ if (!this._resultsFolderTreeElement) {
+ this._resultsFolderTreeElement = new WI.FolderTreeElement(WI.UIString("Results"));
+ this.contentTreeOutline.appendChild(this._resultsFolderTreeElement);
+ }
+ this._resultsFolderTreeElement.expand();
+
let resultFolderTreeElement = new WI.FolderTreeElement(WI.UIString("Run %d").format(index + 1));
if (result instanceof WI.AuditTestResultBase) {
resultFolderTreeElement.subtitle = WI.UIString("Imported");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
