Title: [238871] trunk/Source/WebInspectorUI
- Revision
- 238871
- Author
- mattba...@apple.com
- Date
- 2018-12-04 12:07:09 -0800 (Tue, 04 Dec 2018)
Log Message
Web Inspector: REGRESSION(r238602): Elements: changing selection no longer highlights the selected node
https://bugs.webkit.org/show_bug.cgi?id=192354
<rdar://problem/46444438>
Reviewed by Joseph Pecoraro.
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype._treeKeyDown):
(WI.TreeOutline.prototype._handleMouseDown):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (238870 => 238871)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-04 20:01:00 UTC (rev 238870)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-04 20:07:09 UTC (rev 238871)
@@ -1,3 +1,15 @@
+2018-12-04 Matt Baker <mattba...@apple.com>
+
+ Web Inspector: REGRESSION(r238602): Elements: changing selection no longer highlights the selected node
+ https://bugs.webkit.org/show_bug.cgi?id=192354
+ <rdar://problem/46444438>
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype._treeKeyDown):
+ (WI.TreeOutline.prototype._handleMouseDown):
+
2018-12-04 Joseph Pecoraro <pecor...@apple.com>
Web Inspector: REGRESSION(r238330): Timeline auto-capture does not work after page transition
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (238870 => 238871)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2018-12-04 20:01:00 UTC (rev 238870)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2018-12-04 20:07:09 UTC (rev 238871)
@@ -609,8 +609,11 @@
}
}
- if (!handled)
+ if (!handled) {
+ this._itemWasSelectedByUser = true;
handled = this._selectionController.handleKeyDown(event);
+ this._itemWasSelectedByUser = false;
+ }
if (nextSelectedElement) {
nextSelectedElement.reveal();
@@ -1000,7 +1003,9 @@
if (isNaN(index))
return;
+ this._itemWasSelectedByUser = true;
this._selectionController.handleItemMouseDown(index, event);
+ this._itemWasSelectedByUser = false;
}
_indexOfTreeElement(treeElement)
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
