Title: [238910] trunk/Tools
- Revision
- 238910
- Author
- [email protected]
- Date
- 2018-12-05 14:34:51 -0800 (Wed, 05 Dec 2018)
Log Message
webkitpy: Clean-up apple_additions
https://bugs.webkit.org/show_bug.cgi?id=192413
<rdar://problem/46493491>
Reviewed by Lucas Forschler.
After the addition of watchOS, some functions which were originally iOS specific were
generalized to include all devices.
* Scripts/webkitpy/port/ios_device.py:
(IOSDevicePort._driver_class): Replace iOS specific call with generalized device call.
(IOSDevicePort.path_to_crash_logs): Ditto.
(IOSDevicePort.clean_up_test_run): Ditto.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (238909 => 238910)
--- trunk/Tools/ChangeLog 2018-12-05 22:32:26 UTC (rev 238909)
+++ trunk/Tools/ChangeLog 2018-12-05 22:34:51 UTC (rev 238910)
@@ -1,5 +1,21 @@
2018-12-05 Jonathan Bedard <[email protected]>
+ webkitpy: Clean-up apple_additions
+ https://bugs.webkit.org/show_bug.cgi?id=192413
+ <rdar://problem/46493491>
+
+ Reviewed by Lucas Forschler.
+
+ After the addition of watchOS, some functions which were originally iOS specific were
+ generalized to include all devices.
+
+ * Scripts/webkitpy/port/ios_device.py:
+ (IOSDevicePort._driver_class): Replace iOS specific call with generalized device call.
+ (IOSDevicePort.path_to_crash_logs): Ditto.
+ (IOSDevicePort.clean_up_test_run): Ditto.
+
+2018-12-05 Jonathan Bedard <[email protected]>
+
webkitpy: Ignore case when comparing device types
https://bugs.webkit.org/show_bug.cgi?id=192409
<rdar://problem/46491558>
Modified: trunk/Tools/Scripts/webkitpy/port/ios_device.py (238909 => 238910)
--- trunk/Tools/Scripts/webkitpy/port/ios_device.py 2018-12-05 22:32:26 UTC (rev 238909)
+++ trunk/Tools/Scripts/webkitpy/port/ios_device.py 2018-12-05 22:34:51 UTC (rev 238910)
@@ -46,7 +46,7 @@
def _driver_class(self):
if apple_additions():
- return apple_additions().ios_device_driver()
+ return apple_additions().device_driver()
return super(IOSDevicePort, self)._driver_class()
@classmethod
@@ -61,7 +61,7 @@
def path_to_crash_logs(self):
if not apple_additions():
raise RuntimeError(self.NO_ON_DEVICE_TESTING)
- return apple_additions().ios_crash_log_path()
+ return apple_additions().device_crash_log_path()
def _look_for_all_crash_logs_in_log_dir(self, newer_than):
log_list = {}
@@ -111,4 +111,4 @@
def clean_up_test_run(self):
super(IOSDevicePort, self).clean_up_test_run()
- apple_additions().ios_device_clean_up_test_run(self, self._path_to_driver(), self._build_path())
+ apple_additions().device_clean_up_test_run(self, self._path_to_driver(), self._build_path())
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
