Title: [238919] trunk/Source/WebKit
- Revision
- 238919
- Author
- [email protected]
- Date
- 2018-12-05 18:28:23 -0800 (Wed, 05 Dec 2018)
Log Message
[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061
Reviewed by Dewei Zhu.
Part 1.
Add some loggings to determine possible causes for the flakiness.
* UIProcess/WebAuthentication/Cocoa/HidService.mm:
(WebKit::HidService::continueAddDeviceAfterGetInfo):
* UIProcess/WebAuthentication/Mock/MockHidService.cpp:
(WebKit::MockHidService::platformStartDiscovery):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (238918 => 238919)
--- trunk/Source/WebKit/ChangeLog 2018-12-06 00:26:27 UTC (rev 238918)
+++ trunk/Source/WebKit/ChangeLog 2018-12-06 02:28:23 UTC (rev 238919)
@@ -1,3 +1,19 @@
+2018-12-05 Jiewen Tan <[email protected]>
+
+ [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=192061
+
+ Reviewed by Dewei Zhu.
+
+ Part 1.
+
+ Add some loggings to determine possible causes for the flakiness.
+
+ * UIProcess/WebAuthentication/Cocoa/HidService.mm:
+ (WebKit::HidService::continueAddDeviceAfterGetInfo):
+ * UIProcess/WebAuthentication/Mock/MockHidService.cpp:
+ (WebKit::MockHidService::platformStartDiscovery):
+
2018-12-05 Chris Dumez <[email protected]>
Simplify logic inside WebPageProxy::continueNavigationInNewProcess()
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm (238918 => 238919)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm 2018-12-06 00:26:27 UTC (rev 238918)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Cocoa/HidService.mm 2018-12-06 02:28:23 UTC (rev 238919)
@@ -115,6 +115,7 @@
return;
}
// FIXME(191535): Support U2F authenticators.
+ LOG_ERROR("Couldn't parse a ctap get info response.");
}
} // namespace WebKit
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp (238918 => 238919)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp 2018-12-06 00:26:27 UTC (rev 238918)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockHidService.cpp 2018-12-06 02:28:23 UTC (rev 238919)
@@ -43,6 +43,7 @@
{
if (!!m_configuration.hid)
deviceAdded(nullptr);
+ LOG_ERROR("No hid authenticators is available.");
}
UniqueRef<HidConnection> MockHidService::createHidConnection(IOHIDDeviceRef device) const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
