Title: [238927] trunk/Source/WebKit
- Revision
- 238927
- Author
- [email protected]
- Date
- 2018-12-05 22:12:28 -0800 (Wed, 05 Dec 2018)
Log Message
REGRESSION(PSON): Process swapping code doesn't set DisplayID in WebContent process
https://bugs.webkit.org/show_bug.cgi?id=192290
Reviewed by Simon Fraser.
Fixed the bug by updating the DisplayID upon attaching to a WebContent process
after a process swap as well as after the previous WebContent process had crashed.
Unfortunately no new tests since WebKitTestRunner / DumpRenderTree should use 0 as DisplayID
as they have an off-screen NSWindow. The issue that this results in no fallback for
the animation timer is tracked by webkit.org/b/192448.
* UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::didRelaunchProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (238926 => 238927)
--- trunk/Source/WebKit/ChangeLog 2018-12-06 04:45:57 UTC (rev 238926)
+++ trunk/Source/WebKit/ChangeLog 2018-12-06 06:12:28 UTC (rev 238927)
@@ -1,3 +1,20 @@
+2018-12-05 Ryosuke Niwa <[email protected]>
+
+ REGRESSION(PSON): Process swapping code doesn't set DisplayID in WebContent process
+ https://bugs.webkit.org/show_bug.cgi?id=192290
+
+ Reviewed by Simon Fraser.
+
+ Fixed the bug by updating the DisplayID upon attaching to a WebContent process
+ after a process swap as well as after the previous WebContent process had crashed.
+
+ Unfortunately no new tests since WebKitTestRunner / DumpRenderTree should use 0 as DisplayID
+ as they have an off-screen NSWindow. The issue that this results in no fallback for
+ the animation timer is tracked by webkit.org/b/192448.
+
+ * UIProcess/Cocoa/WebViewImpl.mm:
+ (WebKit::WebViewImpl::didRelaunchProcess):
+
2018-12-05 Youenn Fablet <[email protected]>
Remove a document entry from NetworkMDNSRegister::m_services when document goes away
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm (238926 => 238927)
--- trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2018-12-06 04:45:57 UTC (rev 238926)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebViewImpl.mm 2018-12-06 06:12:28 UTC (rev 238927)
@@ -1498,6 +1498,7 @@
m_gestureController->connectToProcess();
accessibilityRegisterUIProcessTokens();
+ windowDidChangeScreen(); // Make sure DisplayID is set.
}
void WebViewImpl::setDrawsBackground(bool drawsBackground)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
