Title: [238935] trunk/LayoutTests
Revision
238935
Author
[email protected]
Date
2018-12-06 11:32:38 -0800 (Thu, 06 Dec 2018)

Log Message

Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=181957

Reviewed by Youenn Fablet.

Since the timing information is a multiplier of a small delta, it is likely that
two timing information are the same as they are so close that fall into the same
bucket. Therefore, this patch releases the check of 't0 !== t1'.

* http/tests/misc/resource-timing-resolution-expected.txt:
* http/tests/misc/resource-timing-resolution.html:
* platform/ios-wk2/TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (238934 => 238935)


--- trunk/LayoutTests/ChangeLog	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/ChangeLog	2018-12-06 19:32:38 UTC (rev 238935)
@@ -1,3 +1,19 @@
+2018-12-06  Jiewen Tan  <[email protected]>
+
+        Layout Test http/tests/misc/resource-timing-resolution.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=181957
+
+        Reviewed by Youenn Fablet.
+
+        Since the timing information is a multiplier of a small delta, it is likely that
+        two timing information are the same as they are so close that fall into the same
+        bucket. Therefore, this patch releases the check of 't0 !== t1'.
+
+        * http/tests/misc/resource-timing-resolution-expected.txt:
+        * http/tests/misc/resource-timing-resolution.html:
+        * platform/ios-wk2/TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+
 2018-12-06  Truitt Savell  <[email protected]>
 
         imported/w3c/web-platform-tests/css/mediaqueries/test_media_queries.html is flaky timeout

Modified: trunk/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt (238934 => 238935)


--- trunk/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/http/tests/misc/resource-timing-resolution-expected.txt	2018-12-06 19:32:38 UTC (rev 238935)
@@ -3,7 +3,6 @@
 On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
 
 
-PASS t0 !== t1 is true
 PASS shouldBeNearZeroOrOne < 1e-10 || Math.abs(shouldBeNearZeroOrOne - 1) < 1e-10 is true
 PASS successfullyParsed is true
 

Modified: trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html (238934 => 238935)


--- trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/http/tests/misc/resource-timing-resolution.html	2018-12-06 19:32:38 UTC (rev 238935)
@@ -18,7 +18,6 @@
     var entries = performance.getEntries();
     t0 = entries[0].fetchStart;
     t1 = entries[1].fetchStart;
-    shouldBe("t0 !== t1", "true");
 
     var expectedResolutionMilliseconds = 0.005;
     var integerMultipleOfResolution = (t1 - t0) / expectedResolutionMilliseconds;

Modified: trunk/LayoutTests/platform/ios-wk2/TestExpectations (238934 => 238935)


--- trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/platform/ios-wk2/TestExpectations	2018-12-06 19:32:38 UTC (rev 238935)
@@ -1260,8 +1260,6 @@
 
 webkit.org/b/181392 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-waits-for-activate.https.html [ Pass Failure ]
 
-webkit.org/b/181957 [ Release ] http/tests/misc/resource-timing-resolution.html [ Pass Failure ]
-
 webkit.org/b/181821 fast/visual-viewport/ios/caret-after-focus-in-fixed.html [ Pass Failure ]
 
 webkit.org/b/182144 [ Debug ] webgl/1.0.3/conformance/rendering/many-draw-calls.html [ Skip ]

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (238934 => 238935)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-12-06 18:59:44 UTC (rev 238934)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2018-12-06 19:32:38 UTC (rev 238935)
@@ -820,8 +820,6 @@
 
 webkit.org/b/181839 [ Debug ] inspector/debugger/breakpoint-action-log.html [ Pass Timeout ]
 
-webkit.org/b/181957 [ Release ] http/tests/misc/resource-timing-resolution.html [ Pass Failure ]
-
 webkit.org/b/181835 webrtc/captureCanvas-webrtc.html [ Pass Timeout ]
 
 webkit.org/b/177663 media/W3C/video/events/event_progress_manual.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to