Title: [238943] trunk/Tools
- Revision
- 238943
- Author
- [email protected]
- Date
- 2018-12-06 15:05:36 -0800 (Thu, 06 Dec 2018)
Log Message
webkitpy: Ignore case when comparing device types (Follow-up fix)
https://bugs.webkit.org/show_bug.cgi?id=192409
<rdar://problem/46491558>
Unreviewed typo fix.
* Scripts/webkitpy/xcode/device_type_unittest.py:
(DeviceTypeTest.test_comparison_lower_case):
(DeviceTypeTest.test_comparsion_lower_case): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (238942 => 238943)
--- trunk/Tools/ChangeLog 2018-12-06 22:34:54 UTC (rev 238942)
+++ trunk/Tools/ChangeLog 2018-12-06 23:05:36 UTC (rev 238943)
@@ -1,5 +1,17 @@
2018-12-06 Jonathan Bedard <[email protected]>
+ webkitpy: Ignore case when comparing device types (Follow-up fix)
+ https://bugs.webkit.org/show_bug.cgi?id=192409
+ <rdar://problem/46491558>
+
+ Unreviewed typo fix.
+
+ * Scripts/webkitpy/xcode/device_type_unittest.py:
+ (DeviceTypeTest.test_comparison_lower_case):
+ (DeviceTypeTest.test_comparsion_lower_case): Deleted.
+
+2018-12-06 Jonathan Bedard <[email protected]>
+
webkitpy: Create device given lower-case DeviceType
<https://bugs.webkit.org/show_bug.cgi?id=192472>
<rdar://problem/46532650>
Modified: trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py (238942 => 238943)
--- trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py 2018-12-06 22:34:54 UTC (rev 238942)
+++ trunk/Tools/Scripts/webkitpy/xcode/device_type_unittest.py 2018-12-06 23:05:36 UTC (rev 238943)
@@ -144,7 +144,7 @@
self.assertTrue(DeviceType.from_string('iPhone', Version(11, 1)) in DeviceType.from_string('iPhone', Version(11)))
self.assertFalse(DeviceType.from_string('iPhone', Version(11)) in DeviceType.from_string('iPhone', Version(11, 1)))
- def test_comparsion_lower_case(self):
+ def test_comparison_lower_case(self):
self.assertEqual(DeviceType.from_string('iphone X'), DeviceType.from_string('iPhone'))
self.assertEqual(DeviceType.from_string('iphone'), DeviceType.from_string('iPhone X'))
self.assertEqual(DeviceType.from_string('iPhone X'), DeviceType.from_string('iphone'))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
