Title: [238972] trunk/Tools
- Revision
- 238972
- Author
- [email protected]
- Date
- 2018-12-07 15:56:07 -0800 (Fri, 07 Dec 2018)
Log Message
ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
https://bugs.webkit.org/show_bug.cgi?id=192362
<rdar://problem/46460360>
Reviewed by Ryosuke Niwa.
Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
*after* we know for sure we have a network process to communicate the policy to.
This should address the failures on iOS.
* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (238971 => 238972)
--- trunk/Tools/ChangeLog 2018-12-07 23:38:38 UTC (rev 238971)
+++ trunk/Tools/ChangeLog 2018-12-07 23:56:07 UTC (rev 238972)
@@ -1,3 +1,17 @@
+2018-12-07 Chris Dumez <[email protected]>
+
+ ProcessSwap.UseSessionCookiesAfterProcessSwapInPrivateBrowsing API test is failing
+ https://bugs.webkit.org/show_bug.cgi?id=192362
+ <rdar://problem/46460360>
+
+ Reviewed by Ryosuke Niwa.
+
+ Move the call to _setCookieAcceptPolicy *after* we've constructed a WKWebView and thus
+ *after* we know for sure we have a network process to communicate the policy to.
+ This should address the failures on iOS.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
+
2018-12-07 Jiewen Tan <[email protected]>
Add keychain access entitlement to WebKitTestRunnerApp
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm (238971 => 238972)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2018-12-07 23:38:38 UTC (rev 238971)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm 2018-12-07 23:56:07 UTC (rev 238972)
@@ -2993,7 +2993,6 @@
auto processPoolConfiguration = adoptNS([[_WKProcessPoolConfiguration alloc] init]);
processPoolConfiguration.get().processSwapsOnNavigation = YES;
auto processPool = adoptNS([[WKProcessPool alloc] _initWithConfiguration:processPoolConfiguration.get()]);
- [processPool _setCookieAcceptPolicy:NSHTTPCookieAcceptPolicyAlways];
RetainPtr<WKWebsiteDataStore> ephemeralStore = [WKWebsiteDataStore nonPersistentDataStore];
auto webViewConfiguration = adoptNS([[WKWebViewConfiguration alloc] init]);
@@ -3010,6 +3009,8 @@
auto delegate = adoptNS([[PSONNavigationDelegate alloc] init]);
[webView setNavigationDelegate:delegate.get()];
+ [processPool _setCookieAcceptPolicy:NSHTTPCookieAcceptPolicyAlways];
+
NSURLRequest *request = [NSURLRequest requestWithURL:[[NSBundle mainBundle] URLForResource:@"SetSessionCookie" withExtension:@"html" subdirectory:@"TestWebKitAPI.resources"]];
[webView loadRequest:request];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
