Title: [239015] trunk/Source
- Revision
- 239015
- Author
- [email protected]
- Date
- 2018-12-08 20:11:48 -0800 (Sat, 08 Dec 2018)
Log Message
Don't programmatically capitalize safe browsing warning buttons
https://bugs.webkit.org/show_bug.cgi?id=192531
<rdar://problem/46417791>
Reviewed by Darin Adler.
Source/WebCore:
This doesn't work so well in other languages.
Capitalize the source strings in English instead.
* en.lproj/Localizable.strings:
Source/WebKit:
* UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
(makeButton):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239014 => 239015)
--- trunk/Source/WebCore/ChangeLog 2018-12-09 01:55:52 UTC (rev 239014)
+++ trunk/Source/WebCore/ChangeLog 2018-12-09 04:11:48 UTC (rev 239015)
@@ -1,3 +1,16 @@
+2018-12-08 Alex Christensen <[email protected]>
+
+ Don't programmatically capitalize safe browsing warning buttons
+ https://bugs.webkit.org/show_bug.cgi?id=192531
+ <rdar://problem/46417791>
+
+ Reviewed by Darin Adler.
+
+ This doesn't work so well in other languages.
+ Capitalize the source strings in English instead.
+
+ * en.lproj/Localizable.strings:
+
2018-12-08 Frederic Wang <[email protected]>
Allow control over child order when adding nodes to the scrolling tree
Modified: trunk/Source/WebCore/en.lproj/Localizable.strings (239014 => 239015)
--- trunk/Source/WebCore/en.lproj/Localizable.strings 2018-12-09 01:55:52 UTC (rev 239014)
+++ trunk/Source/WebCore/en.lproj/Localizable.strings 2018-12-09 04:11:48 UTC (rev 239015)
@@ -317,7 +317,7 @@
"Go" = "Go";
/* Action from safe browsing warning */
-"Go back" = "Go back";
+"Go Back" = "Go Back";
/* Google Safe Browsing */
"Google Safe Browsing" = "Google Safe Browsing";
@@ -656,7 +656,7 @@
"Show Substitutions" = "Show Substitutions";
/* Action from safe browsing warning */
-"Show details" = "Show details";
+"Show Details" = "Show Details";
/* Title of the context menu item to show when PDFPlugin was used instead of a blocked plugin */
"Show in blocked plug-in" = "Show in blocked plug-in";
Modified: trunk/Source/WebKit/ChangeLog (239014 => 239015)
--- trunk/Source/WebKit/ChangeLog 2018-12-09 01:55:52 UTC (rev 239014)
+++ trunk/Source/WebKit/ChangeLog 2018-12-09 04:11:48 UTC (rev 239015)
@@ -1,5 +1,16 @@
2018-12-08 Alex Christensen <[email protected]>
+ Don't programmatically capitalize safe browsing warning buttons
+ https://bugs.webkit.org/show_bug.cgi?id=192531
+ <rdar://problem/46417791>
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/Cocoa/WKSafeBrowsingWarning.mm:
+ (makeButton):
+
+2018-12-08 Alex Christensen <[email protected]>
+
Safe browsing warning should respect text size from settings
https://bugs.webkit.org/show_bug.cgi?id=192205
Modified: trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm (239014 => 239015)
--- trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm 2018-12-09 01:55:52 UTC (rev 239014)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WKSafeBrowsingWarning.mm 2018-12-09 04:11:48 UTC (rev 239015)
@@ -198,10 +198,9 @@
{
NSString *title = nil;
if (item == WarningItem::ShowDetailsButton)
- title = WEB_UI_NSSTRING(@"Show details", "Action from safe browsing warning");
+ title = WEB_UI_NSSTRING(@"Show Details", "Action from safe browsing warning");
else
- title = WEB_UI_NSSTRING(@"Go back", "Action from safe browsing warning");
- title = [title capitalizedString];
+ title = WEB_UI_NSSTRING(@"Go Back", "Action from safe browsing warning");
#if PLATFORM(MAC)
return [NSButton buttonWithTitle:title target:warning action:action];
#else
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
