Title: [239033] trunk/Source
- Revision
- 239033
- Author
- [email protected]
- Date
- 2018-12-10 09:51:08 -0800 (Mon, 10 Dec 2018)
Log Message
[macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
https://bugs.webkit.org/show_bug.cgi?id=192533
rdar://problem/45732710
Patch by Darin Adler <[email protected]> on 2018-12-10
Reviewed by Anders Carlsson.
Source/WebCore/PAL:
* pal/spi/mac/HIServicesSPI.h: Added kMSHDoNotCreateSendRightOption.
Source/WebKitLegacy/mac:
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
Modified Paths
Diff
Modified: trunk/Source/WebCore/PAL/ChangeLog (239032 => 239033)
--- trunk/Source/WebCore/PAL/ChangeLog 2018-12-10 17:50:38 UTC (rev 239032)
+++ trunk/Source/WebCore/PAL/ChangeLog 2018-12-10 17:51:08 UTC (rev 239033)
@@ -1,3 +1,13 @@
+2018-12-10 Darin Adler <[email protected]>
+
+ [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
+ https://bugs.webkit.org/show_bug.cgi?id=192533
+ rdar://problem/45732710
+
+ Reviewed by Anders Carlsson.
+
+ * pal/spi/mac/HIServicesSPI.h: Added kMSHDoNotCreateSendRightOption.
+
2018-12-09 Saam barati <[email protected]>
Enable HTTP and HTTPS proxies on iOS and make it a property of the NSURLSession
Modified: trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h (239032 => 239033)
--- trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h 2018-12-10 17:50:38 UTC (rev 239032)
+++ trunk/Source/WebCore/PAL/pal/spi/mac/HIServicesSPI.h 2018-12-10 17:51:08 UTC (rev 239033)
@@ -100,6 +100,10 @@
const UInt8* data[5];
};
+enum {
+ kMSHDoNotCreateSendRightOption = 0x4,
+};
+
#endif
typedef UInt32 MSHCreateOptions;
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (239032 => 239033)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-12-10 17:50:38 UTC (rev 239032)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-12-10 17:51:08 UTC (rev 239033)
@@ -1,5 +1,16 @@
2018-12-10 Darin Adler <[email protected]>
+ [macOS] MSHCreateMIGServerSource invocation does not handle send/receive rights correctly
+ https://bugs.webkit.org/show_bug.cgi?id=192533
+ rdar://problem/45732710
+
+ Reviewed by Anders Carlsson.
+
+ * Plugins/Hosted/NetscapePluginHostProxy.mm:
+ (WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy): Pass kMSHDoNotCreateSendRightOption.
+
+2018-12-10 Darin Adler <[email protected]>
+
[macOS] Use mach_port_mod_refs instead of mach_port_destroy
https://bugs.webkit.org/show_bug.cgi?id=192532
rdar://problem/45731047
Modified: trunk/Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostProxy.mm (239032 => 239033)
--- trunk/Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostProxy.mm 2018-12-10 17:50:38 UTC (rev 239032)
+++ trunk/Source/WebKitLegacy/mac/Plugins/Hosted/NetscapePluginHostProxy.mm 2018-12-10 17:51:08 UTC (rev 239033)
@@ -125,7 +125,7 @@
CFRunLoopAddSource(CFRunLoopGetCurrent(), deathPortSource.get(), kCFRunLoopDefaultMode);
- m_clientPortSource = adoptCF(MSHCreateMIGServerSource(nullptr, 0, reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>(&WKWebKitPluginClient_subsystem)), 0, m_clientPort, nullptr));
+ m_clientPortSource = adoptCF(MSHCreateMIGServerSource(nullptr, 0, reinterpret_cast<mig_subsystem_t>(const_cast<struct WKWebKitPluginClient_subsystem*>(&WKWebKitPluginClient_subsystem)), kMSHDoNotCreateSendRightOption, m_clientPort, nullptr));
CFRunLoopAddSource(CFRunLoopGetCurrent(), m_clientPortSource.get(), kCFRunLoopDefaultMode);
CFRunLoopAddSource(CFRunLoopGetCurrent(), m_clientPortSource.get(), (CFStringRef)NSEventTrackingRunLoopMode);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
