Title: [239037] trunk/Source
Revision
239037
Author
[email protected]
Date
2018-12-10 11:45:45 -0800 (Mon, 10 Dec 2018)

Log Message

Use text/_javascript_ as recommended by the HTML specification
https://bugs.webkit.org/show_bug.cgi?id=192525
<rdar://problem/46569636>

Reviewed by Jon Lee.

The HTML specification says we should use text/_javascript_ for
_javascript_ files:
https://html.spec.whatwg.org/multipage/scripting.html#scriptingLanguages:_javascript_-mime-type

Source/WebCore:

* loader/cache/CachedScript.cpp: Replace application/_javascript_ with text/_javascript_.
(WebCore::CachedScript::CachedScript):
* platform/network/ios/WebCoreURLResponseIOS.mm: Ditto.
(WebCore::createExtensionToMIMETypeMap):
* platform/network/mac/WebCoreURLResponse.mm: Ditto.
(WebCore::createExtensionToMIMETypeMap):

Source/WebInspectorUI:

* UserInterface/Base/MIMETypeUtilities.js:
(WI.mimeTypeForFileExtension):
* UserInterface/Views/TextEditor.js:
(WI.TextEditor.prototype._attemptToDetermineMIMEType):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (239036 => 239037)


--- trunk/Source/WebCore/ChangeLog	2018-12-10 19:37:49 UTC (rev 239036)
+++ trunk/Source/WebCore/ChangeLog	2018-12-10 19:45:45 UTC (rev 239037)
@@ -1,5 +1,24 @@
 2018-12-10  Dean Jackson  <[email protected]>
 
+        Use text/_javascript_ as recommended by the HTML specification
+        https://bugs.webkit.org/show_bug.cgi?id=192525
+        <rdar://problem/46569636>
+
+        Reviewed by Jon Lee.
+
+        The HTML specification says we should use text/_javascript_ for
+        _javascript_ files:
+        https://html.spec.whatwg.org/multipage/scripting.html#scriptingLanguages:_javascript_-mime-type
+
+        * loader/cache/CachedScript.cpp: Replace application/_javascript_ with text/_javascript_.
+        (WebCore::CachedScript::CachedScript):
+        * platform/network/ios/WebCoreURLResponseIOS.mm: Ditto.
+        (WebCore::createExtensionToMIMETypeMap):
+        * platform/network/mac/WebCoreURLResponse.mm: Ditto.
+        (WebCore::createExtensionToMIMETypeMap):
+
+2018-12-10  Dean Jackson  <[email protected]>
+
         [iOS] Make WebGPU work with remote layer hosting
         https://bugs.webkit.org/show_bug.cgi?id=192508
         <rdar://problem/46560649>

Modified: trunk/Source/WebCore/loader/cache/CachedScript.cpp (239036 => 239037)


--- trunk/Source/WebCore/loader/cache/CachedScript.cpp	2018-12-10 19:37:49 UTC (rev 239036)
+++ trunk/Source/WebCore/loader/cache/CachedScript.cpp	2018-12-10 19:45:45 UTC (rev 239037)
@@ -38,7 +38,7 @@
 
 CachedScript::CachedScript(CachedResourceRequest&& request, PAL::SessionID sessionID)
     : CachedResource(WTFMove(request), Type::Script, sessionID)
-    , m_decoder(TextResourceDecoder::create("application/_javascript_"_s, request.charset()))
+    , m_decoder(TextResourceDecoder::create("text/_javascript_"_s, request.charset()))
 {
 }
 

Modified: trunk/Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm (239036 => 239037)


--- trunk/Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm	2018-12-10 19:37:49 UTC (rev 239036)
+++ trunk/Source/WebCore/platform/network/ios/WebCoreURLResponseIOS.mm	2018-12-10 19:45:45 UTC (rev 239037)
@@ -47,7 +47,7 @@
     };
 
     CFStringRef values[] = {
-        CFSTR("application/_javascript_")
+        CFSTR("text/_javascript_")
     };
 
     ASSERT(sizeof(keys) == sizeof(values));

Modified: trunk/Source/WebCore/platform/network/mac/WebCoreURLResponse.mm (239036 => 239037)


--- trunk/Source/WebCore/platform/network/mac/WebCoreURLResponse.mm	2018-12-10 19:37:49 UTC (rev 239036)
+++ trunk/Source/WebCore/platform/network/mac/WebCoreURLResponse.mm	2018-12-10 19:45:45 UTC (rev 239037)
@@ -212,7 +212,7 @@
         CFSTR("application/x-troff-me"),
         CFSTR("model/mesh"),
         CFSTR("application/vnd.mif"),
-        CFSTR("application/_javascript_"),
+        CFSTR("text/_javascript_"),
         CFSTR("video/x-sgi-movie"),
         CFSTR("audio/mpeg"),
         CFSTR("audio/mpeg"),

Modified: trunk/Source/WebInspectorUI/ChangeLog (239036 => 239037)


--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-10 19:37:49 UTC (rev 239036)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-10 19:45:45 UTC (rev 239037)
@@ -1,3 +1,20 @@
+2018-12-10  Dean Jackson  <[email protected]>
+
+        Use text/_javascript_ as recommended by the HTML specification
+        https://bugs.webkit.org/show_bug.cgi?id=192525
+        <rdar://problem/46569636>
+
+        Reviewed by Jon Lee.
+
+        The HTML specification says we should use text/_javascript_ for
+        _javascript_ files:
+        https://html.spec.whatwg.org/multipage/scripting.html#scriptingLanguages:_javascript_-mime-type
+
+        * UserInterface/Base/MIMETypeUtilities.js:
+        (WI.mimeTypeForFileExtension):
+        * UserInterface/Views/TextEditor.js:
+        (WI.TextEditor.prototype._attemptToDetermineMIMEType):
+
 2018-12-06  Matt Baker  <[email protected]>
 
         Web Inspector: REGRESSION(r238602): Elements: collapsing a DOM node with the left arrow doesn't work

Modified: trunk/Source/WebInspectorUI/UserInterface/Base/MIMETypeUtilities.js (239036 => 239037)


--- trunk/Source/WebInspectorUI/UserInterface/Base/MIMETypeUtilities.js	2018-12-10 19:37:49 UTC (rev 239036)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/MIMETypeUtilities.js	2018-12-10 19:45:45 UTC (rev 239037)
@@ -48,8 +48,8 @@
         "xml": "text/xml",
 
         // Script types.
-        "js": "application/_javascript_",
-        "mjs": "application/_javascript_",
+        "js": "text/_javascript_",
+        "mjs": "text/_javascript_",
         "json": "application/json",
         "clj": "text/x-clojure",
         "coffee": "text/x-coffeescript",

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js (239036 => 239037)


--- trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js	2018-12-10 19:37:49 UTC (rev 239036)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TextEditor.js	2018-12-10 19:45:45 UTC (rev 239037)
@@ -909,7 +909,7 @@
             if (!formattedText)
                 return;
 
-            this.mimeType = "application/_javascript_";
+            this.mimeType = "text/_javascript_";
 
             if (Date.now() - startTime < 100)
                 this.updateFormattedState(true);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to