Title: [239059] trunk/Source/WebKit
- Revision
- 239059
- Author
- [email protected]
- Date
- 2018-12-10 16:32:38 -0800 (Mon, 10 Dec 2018)
Log Message
Animated scrolling on Google Maps scrolls the page in addition to moving the map
https://bugs.webkit.org/show_bug.cgi?id=192521
<rdar://problem/46382007>
Reviewed by Sam Weinig.
* Platform/spi/ios/UIKitSPI.h:
* UIProcess/ios/WKKeyboardScrollingAnimator.mm:
(-[WKKeyboardScrollViewAnimator rubberbandableDirections]):
Only do keyboard-based rubber-banding in directions that we can actually
scroll, not directions we can only finger-rubber-band in. This effectively
means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}".
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239058 => 239059)
--- trunk/Source/WebKit/ChangeLog 2018-12-11 00:08:09 UTC (rev 239058)
+++ trunk/Source/WebKit/ChangeLog 2018-12-11 00:32:38 UTC (rev 239059)
@@ -1,3 +1,18 @@
+2018-12-10 Tim Horton <[email protected]>
+
+ Animated scrolling on Google Maps scrolls the page in addition to moving the map
+ https://bugs.webkit.org/show_bug.cgi?id=192521
+ <rdar://problem/46382007>
+
+ Reviewed by Sam Weinig.
+
+ * Platform/spi/ios/UIKitSPI.h:
+ * UIProcess/ios/WKKeyboardScrollingAnimator.mm:
+ (-[WKKeyboardScrollViewAnimator rubberbandableDirections]):
+ Only do keyboard-based rubber-banding in directions that we can actually
+ scroll, not directions we can only finger-rubber-band in. This effectively
+ means keyboard scrolling will ignore "alwaysBounce{Vertical, Horizontal}".
+
2018-12-10 Commit Queue <[email protected]>
Unreviewed, rolling out r239023.
Modified: trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h (239058 => 239059)
--- trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2018-12-11 00:08:09 UTC (rev 239058)
+++ trunk/Source/WebKit/Platform/spi/ios/UIKitSPI.h 2018-12-11 00:32:38 UTC (rev 239059)
@@ -1054,8 +1054,8 @@
- (void)_adjustForAutomaticKeyboardInfo:(NSDictionary *)info animated:(BOOL)animated lastAdjustment:(CGFloat*)lastAdjustment;
- (BOOL)_isScrollingToTop;
- (CGPoint)_animatedTargetOffset;
-- (BOOL)_canScrollX;
-- (BOOL)_canScrollY;
+- (BOOL)_canScrollWithoutBouncingX;
+- (BOOL)_canScrollWithoutBouncingY;
- (void)_setContentOffsetWithDecelerationAnimation:(CGPoint)contentOffset;
- (CGPoint)_adjustedContentOffsetForContentOffset:(CGPoint)contentOffset;
- (void)_flashScrollIndicatorsPersistingPreviousFlashes:(BOOL)persisting;
Modified: trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm (239058 => 239059)
--- trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm 2018-12-11 00:08:09 UTC (rev 239058)
+++ trunk/Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm 2018-12-11 00:32:38 UTC (rev 239059)
@@ -678,9 +678,9 @@
WebCore::RectEdges<bool> edges;
- edges.setTop(scrollView._canScrollY);
+ edges.setTop(scrollView._canScrollWithoutBouncingY);
edges.setBottom(edges.top());
- edges.setLeft(scrollView._canScrollX);
+ edges.setLeft(scrollView._canScrollWithoutBouncingX);
edges.setRight(edges.left());
return edges;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
