Title: [239066] trunk/Source/WebInspectorUI
- Revision
- 239066
- Author
- [email protected]
- Date
- 2018-12-10 19:50:25 -0800 (Mon, 10 Dec 2018)
Log Message
Web Inspector: REGRESSION (r238599): unable to select specific timeline
https://bugs.webkit.org/show_bug.cgi?id=192443
<rdar://problem/46608087>
Reviewed by Joseph Pecoraro.
When determining the trailing horizontal edge for TreeElement mouse
events, TreeOutline should not assume that its containing DOM element
is only as wide as its <ol> element.
* UserInterface/Views/TreeOutline.js:
(WI.TreeOutline.prototype.treeElementFromEvent):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (239065 => 239066)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-11 03:46:19 UTC (rev 239065)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-11 03:50:25 UTC (rev 239066)
@@ -1,5 +1,20 @@
2018-12-10 Matt Baker <[email protected]>
+ Web Inspector: REGRESSION (r238599): unable to select specific timeline
+ https://bugs.webkit.org/show_bug.cgi?id=192443
+ <rdar://problem/46608087>
+
+ Reviewed by Joseph Pecoraro.
+
+ When determining the trailing horizontal edge for TreeElement mouse
+ events, TreeOutline should not assume that its containing DOM element
+ is only as wide as its <ol> element.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WI.TreeOutline.prototype.treeElementFromEvent):
+
+2018-12-10 Matt Baker <[email protected]>
+
Web Inspector: Move TreeOutlineGroup coordination out of TreeElement
https://bugs.webkit.org/show_bug.cgi?id=192487
<rdar://problem/46543431>
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (239065 => 239066)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2018-12-11 03:46:19 UTC (rev 239065)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2018-12-11 03:50:25 UTC (rev 239066)
@@ -888,12 +888,18 @@
treeElementFromEvent(event)
{
- let scrollContainer = this.element.parentElement;
-
+ // We can't take event.pageX to be our X coordinate, since the TreeElement
+ // could be indented, in which case we can't rely on its DOM element to be
+ // under the mouse.
// We choose this X coordinate based on the knowledge that our list
// items extend at least to the trailing edge of the outer <ol> container.
// In the no-word-wrap mode the outer <ol> may be wider than the tree container
- // (and partially hidden), in which case we are left to use only its trailing boundary.
+ // (and partially hidden), in which case we use the edge of its container.
+
+ let scrollContainer = this.element.parentElement;
+ if (scrollContainer.offsetWidth > this.element.offsetWidth)
+ scrollContainer = this.element;
+
// This adjustment is useful in order to find the inner-most tree element that
// lines up horizontally with the location of the event. If the mouse event
// happened in the space preceding a nested tree element (in the leading indentated
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
