Title: [239097] trunk/Source/WebKitLegacy
- Revision
- 239097
- Author
- [email protected]
- Date
- 2018-12-11 21:18:42 -0800 (Tue, 11 Dec 2018)
Log Message
[Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
https://bugs.webkit.org/show_bug.cgi?id=192581
Reviewed by Alex Christensen.
Conventionally, WebKit COM interface adds a new interface with
same name methods with the old interface. For example, both
IWebEditingDelegate and IWebEditingDelegate2 interfaces has
shouldInsertNode method.
This is a part of public API, can't be renamed.
* PlatformWin.cmake: Added -Wno-overloaded-virtual compiler option
for WebKitLegacy
Modified Paths
Diff
Modified: trunk/Source/WebKitLegacy/ChangeLog (239096 => 239097)
--- trunk/Source/WebKitLegacy/ChangeLog 2018-12-12 03:58:41 UTC (rev 239096)
+++ trunk/Source/WebKitLegacy/ChangeLog 2018-12-12 05:18:42 UTC (rev 239097)
@@ -1,3 +1,20 @@
+2018-12-11 Fujii Hironori <[email protected]>
+
+ [Win][WebKitLegacy][Clang] WebKit.h warning: 'IWebEditingDelegate2::shouldInsertNode' hides overloaded virtual function [-Woverloaded-virtual]
+ https://bugs.webkit.org/show_bug.cgi?id=192581
+
+ Reviewed by Alex Christensen.
+
+ Conventionally, WebKit COM interface adds a new interface with
+ same name methods with the old interface. For example, both
+ IWebEditingDelegate and IWebEditingDelegate2 interfaces has
+ shouldInsertNode method.
+
+ This is a part of public API, can't be renamed.
+
+ * PlatformWin.cmake: Added -Wno-overloaded-virtual compiler option
+ for WebKitLegacy
+
2018-12-06 Alex Christensen <[email protected]>
Remove unused LoaderStrategy::storeDerivedDataToCache and associated dead code
Modified: trunk/Source/WebKitLegacy/PlatformWin.cmake (239096 => 239097)
--- trunk/Source/WebKitLegacy/PlatformWin.cmake 2018-12-12 03:58:41 UTC (rev 239096)
+++ trunk/Source/WebKitLegacy/PlatformWin.cmake 2018-12-12 05:18:42 UTC (rev 239097)
@@ -277,6 +277,10 @@
endif ()
endif ()
+if (COMPILER_IS_GCC_OR_CLANG)
+ WEBKIT_ADD_TARGET_CXX_FLAGS(WebKitLegacy -Wno-overloaded-virtual)
+endif ()
+
list(APPEND WebKitLegacy_SOURCES ${WebKitLegacy_INCLUDES} ${WebKitLegacy_SOURCES_Classes} ${WebKitLegacy_SOURCES_WebCoreSupport})
source_group(Includes FILES ${WebKitLegacy_INCLUDES})
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
