Title: [239133] trunk/Source/WebKit
- Revision
- 239133
- Author
- [email protected]
- Date
- 2018-12-12 16:30:13 -0800 (Wed, 12 Dec 2018)
Log Message
Unreviewed, rolling out r239129 and r239131.
https://bugs.webkit.org/show_bug.cgi?id=192646
Casued macOS and iOS Debug testing to fail early (Requested by
Truitt on #webkit).
Reverted changesets:
"Unreviewed build fix for WinCairo Debug after r239080(?)."
https://trac.webkit.org/changeset/239129
"Unreviewed fix for Cocoa Debug test instability following
r239129."
https://trac.webkit.org/changeset/239131
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239132 => 239133)
--- trunk/Source/WebKit/ChangeLog 2018-12-12 23:57:10 UTC (rev 239132)
+++ trunk/Source/WebKit/ChangeLog 2018-12-13 00:30:13 UTC (rev 239133)
@@ -1,3 +1,20 @@
+2018-12-12 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r239129 and r239131.
+ https://bugs.webkit.org/show_bug.cgi?id=192646
+
+ Casued macOS and iOS Debug testing to fail early (Requested by
+ Truitt on #webkit).
+
+ Reverted changesets:
+
+ "Unreviewed build fix for WinCairo Debug after r239080(?)."
+ https://trac.webkit.org/changeset/239129
+
+ "Unreviewed fix for Cocoa Debug test instability following
+ r239129."
+ https://trac.webkit.org/changeset/239131
+
2018-12-12 Vivek Seth <[email protected]>
HTTPS Upgrade: Figure out if/how to tell clients that the HTTPS upgrade happened
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.cpp (239132 => 239133)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-12-12 23:57:10 UTC (rev 239132)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.cpp 2018-12-13 00:30:13 UTC (rev 239133)
@@ -2759,6 +2759,12 @@
};
}
+NO_RETURN_DUE_TO_ASSERT void WebPageProxy::didFailToSuspendAfterProcessSwap()
+{
+ // Only the SuspendedPageProxy should be getting this call.
+ ASSERT_NOT_REACHED();
+}
+
void WebPageProxy::setUserAgent(String&& userAgent)
{
if (m_userAgent == userAgent)
Modified: trunk/Source/WebKit/UIProcess/WebPageProxy.h (239132 => 239133)
--- trunk/Source/WebKit/UIProcess/WebPageProxy.h 2018-12-12 23:57:10 UTC (rev 239132)
+++ trunk/Source/WebKit/UIProcess/WebPageProxy.h 2018-12-13 00:30:13 UTC (rev 239133)
@@ -1566,10 +1566,8 @@
void reattachToWebProcess();
void swapToWebProcess(Ref<WebProcessProxy>&&, std::unique_ptr<SuspendedPageProxy>&&, ShouldDelayAttachingDrawingArea);
+ void didFailToSuspendAfterProcessSwap();
- // Only the SuspendedPageProxy should be getting this call.
- NO_RETURN_DUE_TO_ASSERT void didFailToSuspendAfterProcessSwap() { ASSERT_NOT_REACHED(); }
-
void finishAttachingToWebProcess(ShouldDelayAttachingDrawingArea = ShouldDelayAttachingDrawingArea::No);
RefPtr<API::Navigation> reattachToWebProcessForReload();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
