Title: [239166] trunk/Source/WebKit
- Revision
- 239166
- Author
- [email protected]
- Date
- 2018-12-13 08:09:36 -0800 (Thu, 13 Dec 2018)
Log Message
[meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds
https://bugs.webkit.org/show_bug.cgi?id=192449
<rdar://problem/46595508>
Reviewed by Darin Adler.
Part 6: Files in plugin process and UI process.
* PluginProcess/PluginControllerProxy.cpp:
* PluginProcess/PluginProcess.cpp:
* PluginProcess/WebProcessConnection.cpp:
* UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
* UIProcess/WebStorage/LocalStorageDatabase.cpp:
* UIProcess/mac/WebPageProxyMac.mm:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239165 => 239166)
--- trunk/Source/WebKit/ChangeLog 2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/ChangeLog 2018-12-13 16:09:36 UTC (rev 239166)
@@ -1,3 +1,20 @@
+2018-12-13 Chris Fleizach <[email protected]>
+
+ [meta][WebKit] Remove using namespace WebCore and WebKit in the global scope for unified source builds
+ https://bugs.webkit.org/show_bug.cgi?id=192449
+ <rdar://problem/46595508>
+
+ Reviewed by Darin Adler.
+
+ Part 6: Files in plugin process and UI process.
+
+ * PluginProcess/PluginControllerProxy.cpp:
+ * PluginProcess/PluginProcess.cpp:
+ * PluginProcess/WebProcessConnection.cpp:
+ * UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:
+ * UIProcess/WebStorage/LocalStorageDatabase.cpp:
+ * UIProcess/mac/WebPageProxyMac.mm:
+
2018-12-13 Eric Carlson <[email protected]>
[MediaStream] Calculate width or height when constraints contain only the other
Modified: trunk/Source/WebKit/PluginProcess/PluginControllerProxy.cpp (239165 => 239166)
--- trunk/Source/WebKit/PluginProcess/PluginControllerProxy.cpp 2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/PluginProcess/PluginControllerProxy.cpp 2018-12-13 16:09:36 UTC (rev 239166)
@@ -51,10 +51,9 @@
#include "LayerHostingContext.h"
#endif
+namespace WebKit {
using namespace WebCore;
-namespace WebKit {
-
PluginControllerProxy::PluginControllerProxy(WebProcessConnection* connection, const PluginCreationParameters& creationParameters)
: m_connection(connection)
, m_pluginInstanceID(creationParameters.pluginInstanceID)
Modified: trunk/Source/WebKit/PluginProcess/PluginProcess.cpp (239165 => 239166)
--- trunk/Source/WebKit/PluginProcess/PluginProcess.cpp 2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/PluginProcess/PluginProcess.cpp 2018-12-13 16:09:36 UTC (rev 239166)
@@ -49,10 +49,10 @@
#include <crt_externs.h>
#endif
+namespace WebKit {
+
using namespace WebCore;
-namespace WebKit {
-
NO_RETURN static void callExit(IPC::Connection*)
{
_exit(EXIT_SUCCESS);
Modified: trunk/Source/WebKit/PluginProcess/WebProcessConnection.cpp (239165 => 239166)
--- trunk/Source/WebKit/PluginProcess/WebProcessConnection.cpp 2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/PluginProcess/WebProcessConnection.cpp 2018-12-13 16:09:36 UTC (rev 239166)
@@ -44,10 +44,9 @@
#include <unistd.h>
#endif
+namespace WebKit {
using namespace WebCore;
-namespace WebKit {
-
static IPC::Connection* currentConnection;
RefPtr<WebProcessConnection> WebProcessConnection::create(IPC::Connection::Identifier connectionIdentifier)
Modified: trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm (239165 => 239166)
--- trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm 2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm 2018-12-13 16:09:36 UTC (rev 239166)
@@ -38,10 +38,9 @@
#import <pal/spi/cocoa/QuartzCoreSPI.h>
#import <wtf/SoftLinking.h>
+namespace WebKit {
using namespace WebCore;
-namespace WebKit {
-
static RetainPtr<UIView> createRemoteView(pid_t pid, uint32_t contextID)
{
#if USE(UIREMOTEVIEW_CONTEXT_HOSTING)
Modified: trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp (239165 => 239166)
--- trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp 2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/UIProcess/WebStorage/LocalStorageDatabase.cpp 2018-12-13 16:09:36 UTC (rev 239166)
@@ -38,13 +38,12 @@
#include <wtf/text/StringHash.h>
#include <wtf/text/WTFString.h>
-using namespace WebCore;
-
static const auto databaseUpdateInterval = 1_s;
static const int maximumItemsToUpdate = 100;
namespace WebKit {
+using namespace WebCore;
Ref<LocalStorageDatabase> LocalStorageDatabase::create(Ref<WorkQueue>&& queue, Ref<LocalStorageDatabaseTracker>&& tracker, const SecurityOriginData& securityOrigin)
{
Modified: trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm (239165 => 239166)
--- trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm 2018-12-13 16:00:01 UTC (rev 239165)
+++ trunk/Source/WebKit/UIProcess/mac/WebPageProxyMac.mm 2018-12-13 16:09:36 UTC (rev 239166)
@@ -67,8 +67,6 @@
#define MESSAGE_CHECK(assertion) MESSAGE_CHECK_BASE(assertion, process().connection())
#define MESSAGE_CHECK_URL(url) MESSAGE_CHECK_BASE(checkURLReceivedFromCurrentOrPreviousWebProcess(url), m_process->connection())
-using namespace WebCore;
-
@interface NSApplication ()
- (BOOL)isSpeaking;
- (void)speakString:(NSString *)string;
@@ -107,7 +105,8 @@
#endif
namespace WebKit {
-
+using namespace WebCore;
+
static inline bool expectsLegacyImplicitRubberBandControl()
{
if (MacApplication::isSafari()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
