Title: [239177] trunk/Source/WTF
- Revision
- 239177
- Author
- [email protected]
- Date
- 2018-12-13 12:49:10 -0800 (Thu, 13 Dec 2018)
Log Message
clang-tidy: Fix unnecessary parameter copies in ParallelHelperPool.cpp
<https://webkit.org/b/192666>
<rdar://problem/46697952>
Reviewed by Alex Christensen.
* wtf/ParallelHelperPool.cpp:
(WTF::ParallelHelperClient::ParallelHelperClient): Use rvalue
reference and WTFMove().
(WTF::ParallelHelperClient::setTask): Ditto.
(WTF::ParallelHelperClient::runTaskInParallel): Ditto.
(WTF::ParallelHelperClient::runTask): Use const reference.
* wtf/ParallelHelperPool.h: Update declarations to match
implementations.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (239176 => 239177)
--- trunk/Source/WTF/ChangeLog 2018-12-13 20:48:57 UTC (rev 239176)
+++ trunk/Source/WTF/ChangeLog 2018-12-13 20:49:10 UTC (rev 239177)
@@ -1,3 +1,20 @@
+2018-12-13 David Kilzer <[email protected]>
+
+ clang-tidy: Fix unnecessary parameter copies in ParallelHelperPool.cpp
+ <https://webkit.org/b/192666>
+ <rdar://problem/46697952>
+
+ Reviewed by Alex Christensen.
+
+ * wtf/ParallelHelperPool.cpp:
+ (WTF::ParallelHelperClient::ParallelHelperClient): Use rvalue
+ reference and WTFMove().
+ (WTF::ParallelHelperClient::setTask): Ditto.
+ (WTF::ParallelHelperClient::runTaskInParallel): Ditto.
+ (WTF::ParallelHelperClient::runTask): Use const reference.
+ * wtf/ParallelHelperPool.h: Update declarations to match
+ implementations.
+
2018-12-12 Alex Christensen <[email protected]>
Implement safe browsing in WebKit on WatchOS
Modified: trunk/Source/WTF/wtf/ParallelHelperPool.cpp (239176 => 239177)
--- trunk/Source/WTF/wtf/ParallelHelperPool.cpp 2018-12-13 20:48:57 UTC (rev 239176)
+++ trunk/Source/WTF/wtf/ParallelHelperPool.cpp 2018-12-13 20:49:10 UTC (rev 239177)
@@ -32,8 +32,8 @@
namespace WTF {
-ParallelHelperClient::ParallelHelperClient(RefPtr<ParallelHelperPool> pool)
- : m_pool(pool)
+ParallelHelperClient::ParallelHelperClient(RefPtr<ParallelHelperPool>&& pool)
+ : m_pool(WTFMove(pool))
{
LockHolder locker(*m_pool->m_lock);
RELEASE_ASSERT(!m_pool->m_isDying);
@@ -54,11 +54,11 @@
}
}
-void ParallelHelperClient::setTask(RefPtr<SharedTask<void ()>> task)
+void ParallelHelperClient::setTask(RefPtr<SharedTask<void ()>>&& task)
{
LockHolder locker(*m_pool->m_lock);
RELEASE_ASSERT(!m_task);
- m_task = task;
+ m_task = WTFMove(task);
m_pool->didMakeWorkAvailable(locker);
}
@@ -81,9 +81,9 @@
runTask(task);
}
-void ParallelHelperClient::runTaskInParallel(RefPtr<SharedTask<void ()>> task)
+void ParallelHelperClient::runTaskInParallel(RefPtr<SharedTask<void ()>>&& task)
{
- setTask(task);
+ setTask(WTFMove(task));
doSomeHelping();
finish();
}
@@ -104,7 +104,7 @@
return m_task;
}
-void ParallelHelperClient::runTask(RefPtr<SharedTask<void ()>> task)
+void ParallelHelperClient::runTask(const RefPtr<SharedTask<void ()>>& task)
{
RELEASE_ASSERT(m_numActive);
RELEASE_ASSERT(task);
Modified: trunk/Source/WTF/wtf/ParallelHelperPool.h (239176 => 239177)
--- trunk/Source/WTF/wtf/ParallelHelperPool.h 2018-12-13 20:48:57 UTC (rev 239176)
+++ trunk/Source/WTF/wtf/ParallelHelperPool.h 2018-12-13 20:49:10 UTC (rev 239177)
@@ -131,10 +131,10 @@
WTF_MAKE_NONCOPYABLE(ParallelHelperClient);
WTF_MAKE_FAST_ALLOCATED;
public:
- WTF_EXPORT_PRIVATE ParallelHelperClient(RefPtr<ParallelHelperPool>);
+ WTF_EXPORT_PRIVATE ParallelHelperClient(RefPtr<ParallelHelperPool>&&);
WTF_EXPORT_PRIVATE ~ParallelHelperClient();
- WTF_EXPORT_PRIVATE void setTask(RefPtr<SharedTask<void ()>>);
+ WTF_EXPORT_PRIVATE void setTask(RefPtr<SharedTask<void ()>>&&);
template<typename Functor>
void setFunction(const Functor& functor)
@@ -150,7 +150,7 @@
// client->setTask(task);
// client->doSomeHelping();
// client->finish();
- WTF_EXPORT_PRIVATE void runTaskInParallel(RefPtr<SharedTask<void ()>>);
+ WTF_EXPORT_PRIVATE void runTaskInParallel(RefPtr<SharedTask<void ()>>&&);
// Equivalent to:
// client->setFunction(functor);
@@ -170,7 +170,7 @@
void finish(const AbstractLocker&);
RefPtr<SharedTask<void ()>> claimTask(const AbstractLocker&);
- void runTask(RefPtr<SharedTask<void ()>>);
+ void runTask(const RefPtr<SharedTask<void ()>>&);
RefPtr<ParallelHelperPool> m_pool;
RefPtr<SharedTask<void ()>> m_task;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
