Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (239182 => 239183)
--- trunk/Source/_javascript_Core/ChangeLog 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-12-13 23:20:35 UTC (rev 239183)
@@ -1,3 +1,12 @@
+2018-12-13 Devin Rousso <[email protected]>
+
+ Web Inspector: remove DOM.BackendNodeId and associated commands/events
+ https://bugs.webkit.org/show_bug.cgi?id=192478
+
+ Reviewed by Matt Baker.
+
+ * inspector/protocol/DOM.json:
+
2018-12-13 Caio Lima <[email protected]>
[BigInt] Add ValueDiv into DFG
Modified: trunk/Source/_javascript_Core/inspector/protocol/DOM.json (239182 => 239183)
--- trunk/Source/_javascript_Core/inspector/protocol/DOM.json 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/_javascript_Core/inspector/protocol/DOM.json 2018-12-13 23:20:35 UTC (rev 239183)
@@ -9,11 +9,6 @@
"description": "Unique DOM node identifier."
},
{
- "id": "BackendNodeId",
- "type": "integer",
- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
- },
- {
"id": "EventListenerId",
"type": "integer",
"description": "Unique event listener identifier."
@@ -453,23 +448,6 @@
]
},
{
- "name": "pushNodeByBackendIdToFrontend",
- "description": "Requests that the node is sent to the caller given its backend node id.",
- "parameters": [
- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
- ],
- "returns": [
- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
- ]
- },
- {
- "name": "releaseBackendNodeIds",
- "description": "Requests that group of <code>BackendNodeIds</code> is released.",
- "parameters": [
- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." }
- ]
- },
- {
"name": "resolveNode",
"description": "Resolves _javascript_ node object for given node id.",
"parameters": [
Modified: trunk/Source/WebCore/ChangeLog (239182 => 239183)
--- trunk/Source/WebCore/ChangeLog 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebCore/ChangeLog 2018-12-13 23:20:35 UTC (rev 239183)
@@ -1,3 +1,19 @@
+2018-12-13 Devin Rousso <[email protected]>
+
+ Web Inspector: remove DOM.BackendNodeId and associated commands/events
+ https://bugs.webkit.org/show_bug.cgi?id=192478
+
+ Reviewed by Matt Baker.
+
+ Removing unused code, so no change in functionality.
+
+ * inspector/agents/InspectorDOMAgent.h:
+ * inspector/agents/InspectorDOMAgent.cpp:
+ (WebCore::InspectorDOMAgent::discardBindings):
+ (WebCore::InspectorDOMAgent::backendNodeIdForNode): Deleted.
+ (WebCore::InspectorDOMAgent::releaseBackendNodeIds): Deleted.
+ (WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend): Deleted.
+
2018-12-13 Chris Dumez <[email protected]>
[PSON] We should not need to navigate to 'about:blank' to suspend pages
Modified: trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp (239182 => 239183)
--- trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.cpp 2018-12-13 23:20:35 UTC (rev 239183)
@@ -546,8 +546,6 @@
m_eventListenerEntries.clear();
releaseDanglingNodes();
m_childrenRequested.clear();
- m_backendIdToNode.clear();
- m_nodeGroupToBackendIdMap.clear();
}
int InspectorDOMAgent::pushNodeToFrontend(ErrorString& errorString, int documentNodeId, Node* nodeToPush)
@@ -684,37 +682,6 @@
return m_documentNodeToIdMap.get(const_cast<Node*>(node));
}
-BackendNodeId InspectorDOMAgent::backendNodeIdForNode(Node* node, const String& nodeGroup)
-{
- if (!node)
- return 0;
-
- if (!m_nodeGroupToBackendIdMap.contains(nodeGroup))
- m_nodeGroupToBackendIdMap.set(nodeGroup, NodeToBackendIdMap());
-
- NodeToBackendIdMap& map = m_nodeGroupToBackendIdMap.find(nodeGroup)->value;
- BackendNodeId id = map.get(node);
- if (!id) {
- id = --m_lastBackendNodeId;
- map.set(node, id);
- m_backendIdToNode.set(id, std::make_pair(node, nodeGroup));
- }
-
- return id;
-}
-
-void InspectorDOMAgent::releaseBackendNodeIds(ErrorString& errorString, const String& nodeGroup)
-{
- if (m_nodeGroupToBackendIdMap.contains(nodeGroup)) {
- NodeToBackendIdMap& map = m_nodeGroupToBackendIdMap.find(nodeGroup)->value;
- for (auto& backendId : map.values())
- m_backendIdToNode.remove(backendId);
- m_nodeGroupToBackendIdMap.remove(nodeGroup);
- return;
- }
- errorString = "Group name not found"_s;
-}
-
void InspectorDOMAgent::setAttributeValue(ErrorString& errorString, int elementId, const String& name, const String& value)
{
Element* element = assertEditableElement(errorString, elementId);
@@ -2557,27 +2524,6 @@
errorString = "No node with given path found"_s;
}
-void InspectorDOMAgent::pushNodeByBackendIdToFrontend(ErrorString& errorString, BackendNodeId backendNodeId, int* nodeId)
-{
- auto iterator = m_backendIdToNode.find(backendNodeId);
- if (iterator == m_backendIdToNode.end()) {
- errorString = "No node with given backend id found"_s;
- return;
- }
-
- Node* node = iterator->value.first;
- String nodeGroup = iterator->value.second;
-
- *nodeId = pushNodePathToFrontend(node);
-
- if (nodeGroup.isEmpty()) {
- m_backendIdToNode.remove(iterator);
- // FIXME: We really do the following only when nodeGroup is the empty string? Seems wrong.
- ASSERT(m_nodeGroupToBackendIdMap.contains(nodeGroup));
- m_nodeGroupToBackendIdMap.find(nodeGroup)->value.remove(node);
- }
-}
-
RefPtr<Inspector::Protocol::Runtime::RemoteObject> InspectorDOMAgent::resolveNode(Node* node, const String& objectGroup)
{
auto* frame = node->document().frame();
Modified: trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h (239182 => 239183)
--- trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebCore/inspector/agents/InspectorDOMAgent.h 2018-12-13 23:20:35 UTC (rev 239183)
@@ -76,7 +76,6 @@
struct HighlightConfig;
typedef String ErrorString;
-typedef int BackendNodeId;
struct EventListenerInfo {
EventListenerInfo(Node* node, const AtomicString& eventType, EventListenerVector&& eventListenerVector)
@@ -141,8 +140,6 @@
void setInspectModeEnabled(ErrorString&, bool enabled, const JSON::Object* highlightConfig) override;
void requestNode(ErrorString&, const String& objectId, int* nodeId) override;
void pushNodeByPathToFrontend(ErrorString&, const String& path, int* nodeId) override;
- void pushNodeByBackendIdToFrontend(ErrorString&, BackendNodeId, int* nodeId) override;
- void releaseBackendNodeIds(ErrorString&, const String& nodeGroup) override;
void hideHighlight(ErrorString&) override;
void highlightRect(ErrorString&, int x, int y, int width, int height, const JSON::Object* color, const JSON::Object* outlineColor, const bool* usePageCoordinates) override;
void highlightQuad(ErrorString&, const JSON::Array& quad, const JSON::Object* color, const JSON::Object* outlineColor, const bool* usePageCoordinates) override;
@@ -193,7 +190,6 @@
Node* nodeForId(int nodeId);
int boundNodeId(const Node*);
void setDOMListener(DOMListener*);
- BackendNodeId backendNodeIdForNode(Node*, const String& nodeGroup);
static String documentURLString(Document*);
@@ -269,16 +265,12 @@
InspectorOverlay* m_overlay { nullptr };
DOMListener* m_domListener { nullptr };
NodeToIdMap m_documentNodeToIdMap;
- typedef HashMap<RefPtr<Node>, BackendNodeId> NodeToBackendIdMap;
- HashMap<String, NodeToBackendIdMap> m_nodeGroupToBackendIdMap;
// Owns node mappings for dangling nodes.
Vector<std::unique_ptr<NodeToIdMap>> m_danglingNodeToIdMaps;
HashMap<int, Node*> m_idToNode;
HashMap<int, NodeToIdMap*> m_idToNodesMap;
HashSet<int> m_childrenRequested;
- HashMap<BackendNodeId, std::pair<Node*, String>> m_backendIdToNode;
int m_lastNodeId { 1 };
- BackendNodeId m_lastBackendNodeId { -1 };
RefPtr<Document> m_document;
typedef HashMap<String, Vector<RefPtr<Node>>> SearchResults;
SearchResults m_searchResults;
Modified: trunk/Source/WebInspectorUI/ChangeLog (239182 => 239183)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-13 23:20:35 UTC (rev 239183)
@@ -1,5 +1,29 @@
2018-12-13 Devin Rousso <[email protected]>
+ Web Inspector: remove DOM.BackendNodeId and associated commands/events
+ https://bugs.webkit.org/show_bug.cgi?id=192478
+
+ Reviewed by Matt Baker.
+
+ * Versions/Inspector-iOS-8.0.json:
+ * Versions/Inspector-iOS-9.0.json:
+ * Versions/Inspector-iOS-9.3.json:
+ * Versions/Inspector-iOS-10.0.json:
+ * Versions/Inspector-iOS-10.3.json:
+ * Versions/Inspector-iOS-11.0.json:
+ * Versions/Inspector-iOS-11.3.json:
+ * Versions/Inspector-iOS-12.0.json:
+ * UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js:
+ * UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js:
+
+2018-12-13 Devin Rousso <[email protected]>
+
Web Inspector: experimental settings reload button disappears after changing more than one setting
https://bugs.webkit.org/show_bug.cgi?id=192645
<rdar://problem/46626204>
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js (239182 => 239183)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js 2018-12-13 23:20:35 UTC (rev 239183)
@@ -136,8 +136,6 @@
InspectorBackend.registerCommand("DOM.hideHighlight", [], []);
InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []);
InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]);
InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]);
InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js (239182 => 239183)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/10.3/InspectorBackendCommands.js 2018-12-13 23:20:35 UTC (rev 239183)
@@ -138,8 +138,6 @@
InspectorBackend.registerCommand("DOM.hideHighlight", [], []);
InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []);
InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]);
InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]);
InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js (239182 => 239183)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.0/InspectorBackendCommands.js 2018-12-13 23:20:35 UTC (rev 239183)
@@ -138,8 +138,6 @@
InspectorBackend.registerCommand("DOM.hideHighlight", [], []);
InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []);
InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]);
InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]);
InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js (239182 => 239183)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/11.3/InspectorBackendCommands.js 2018-12-13 23:20:35 UTC (rev 239183)
@@ -164,8 +164,6 @@
InspectorBackend.registerCommand("DOM.hideHighlight", [], []);
InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []);
InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]);
InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]);
InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js (239182 => 239183)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/12.0/InspectorBackendCommands.js 2018-12-13 23:20:35 UTC (rev 239183)
@@ -165,8 +165,6 @@
InspectorBackend.registerCommand("DOM.hideHighlight", [], []);
InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []);
InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]);
InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]);
InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js (239182 => 239183)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js 2018-12-13 23:20:35 UTC (rev 239183)
@@ -200,8 +200,6 @@
InspectorBackend.registerCommand("DOM.hideHighlight", [], []);
InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []);
InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]);
InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]);
InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js (239182 => 239183)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js 2018-12-13 23:20:35 UTC (rev 239183)
@@ -126,8 +126,6 @@
InspectorBackend.registerCommand("DOM.hideHighlight", [], []);
InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []);
InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]);
InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]);
InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]);
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js (239182 => 239183)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js 2018-12-13 23:20:35 UTC (rev 239183)
@@ -133,8 +133,6 @@
InspectorBackend.registerCommand("DOM.hideHighlight", [], []);
InspectorBackend.registerCommand("DOM.highlightFrame", [{"name": "frameId", "type": "string", "optional": false}, {"name": "contentColor", "type": "object", "optional": true}, {"name": "contentOutlineColor", "type": "object", "optional": true}], []);
InspectorBackend.registerCommand("DOM.pushNodeByPathToFrontend", [{"name": "path", "type": "string", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.pushNodeByBackendIdToFrontend", [{"name": "backendNodeId", "type": "number", "optional": false}], ["nodeId"]);
-InspectorBackend.registerCommand("DOM.releaseBackendNodeIds", [{"name": "nodeGroup", "type": "string", "optional": false}], []);
InspectorBackend.registerCommand("DOM.resolveNode", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "objectGroup", "type": "string", "optional": true}], ["object"]);
InspectorBackend.registerCommand("DOM.getAttributes", [{"name": "nodeId", "type": "number", "optional": false}], ["attributes"]);
InspectorBackend.registerCommand("DOM.moveTo", [{"name": "nodeId", "type": "number", "optional": false}, {"name": "targetNodeId", "type": "number", "optional": false}, {"name": "insertBeforeNodeId", "type": "number", "optional": true}], ["nodeId"]);
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json (239182 => 239183)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.0.json 2018-12-13 23:20:35 UTC (rev 239183)
@@ -656,11 +656,6 @@
"description": "Unique DOM node identifier."
},
{
- "id": "BackendNodeId",
- "type": "integer",
- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
- },
- {
"id": "PseudoType",
"type": "string",
"enum": ["before", "after"],
@@ -1036,23 +1031,6 @@
"description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath"
},
{
- "name": "pushNodeByBackendIdToFrontend",
- "parameters": [
- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
- ],
- "returns": [
- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
- ],
- "description": "Requests that the node is sent to the caller given its backend node id."
- },
- {
- "name": "releaseBackendNodeIds",
- "parameters": [
- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." }
- ],
- "description": "Requests that group of <code>BackendNodeIds</code> is released."
- },
- {
"name": "resolveNode",
"parameters": [
{ "name": "nodeId", "$ref": "NodeId", "description": "Id of the node to resolve." },
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json (239182 => 239183)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-10.3.json 2018-12-13 23:20:35 UTC (rev 239183)
@@ -661,11 +661,6 @@
"description": "Unique DOM node identifier."
},
{
- "id": "BackendNodeId",
- "type": "integer",
- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
- },
- {
"id": "PseudoType",
"type": "string",
"enum": ["before", "after"],
@@ -1050,23 +1045,6 @@
"description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath"
},
{
- "name": "pushNodeByBackendIdToFrontend",
- "parameters": [
- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
- ],
- "returns": [
- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
- ],
- "description": "Requests that the node is sent to the caller given its backend node id."
- },
- {
- "name": "releaseBackendNodeIds",
- "parameters": [
- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." }
- ],
- "description": "Requests that group of <code>BackendNodeIds</code> is released."
- },
- {
"name": "resolveNode",
"parameters": [
{ "name": "nodeId", "$ref": "NodeId", "description": "Id of the node to resolve." },
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-11.0.json (239182 => 239183)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-11.0.json 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-11.0.json 2018-12-13 23:20:35 UTC (rev 239183)
@@ -661,11 +661,6 @@
"description": "Unique DOM node identifier."
},
{
- "id": "BackendNodeId",
- "type": "integer",
- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
- },
- {
"id": "PseudoType",
"type": "string",
"enum": ["before", "after"],
@@ -1052,23 +1047,6 @@
]
},
{
- "name": "pushNodeByBackendIdToFrontend",
- "description": "Requests that the node is sent to the caller given its backend node id.",
- "parameters": [
- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
- ],
- "returns": [
- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
- ]
- },
- {
- "name": "releaseBackendNodeIds",
- "description": "Requests that group of <code>BackendNodeIds</code> is released.",
- "parameters": [
- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." }
- ]
- },
- {
"name": "resolveNode",
"description": "Resolves _javascript_ node object for given node id.",
"parameters": [
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-11.3.json (239182 => 239183)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-11.3.json 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-11.3.json 2018-12-13 23:20:35 UTC (rev 239183)
@@ -826,11 +826,6 @@
"description": "Unique DOM node identifier."
},
{
- "id": "BackendNodeId",
- "type": "integer",
- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
- },
- {
"id": "EventListenerId",
"type": "integer",
"description": "Unique event listener identifier."
@@ -1248,23 +1243,6 @@
]
},
{
- "name": "pushNodeByBackendIdToFrontend",
- "description": "Requests that the node is sent to the caller given its backend node id.",
- "parameters": [
- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
- ],
- "returns": [
- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
- ]
- },
- {
- "name": "releaseBackendNodeIds",
- "description": "Requests that group of <code>BackendNodeIds</code> is released.",
- "parameters": [
- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." }
- ]
- },
- {
"name": "resolveNode",
"description": "Resolves _javascript_ node object for given node id.",
"parameters": [
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json (239182 => 239183)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-12.0.json 2018-12-13 23:20:35 UTC (rev 239183)
@@ -834,11 +834,6 @@
"description": "Unique DOM node identifier."
},
{
- "id": "BackendNodeId",
- "type": "integer",
- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
- },
- {
"id": "EventListenerId",
"type": "integer",
"description": "Unique event listener identifier."
@@ -1256,23 +1251,6 @@
]
},
{
- "name": "pushNodeByBackendIdToFrontend",
- "description": "Requests that the node is sent to the caller given its backend node id.",
- "parameters": [
- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
- ],
- "returns": [
- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
- ]
- },
- {
- "name": "releaseBackendNodeIds",
- "description": "Requests that group of <code>BackendNodeIds</code> is released.",
- "parameters": [
- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." }
- ]
- },
- {
"name": "resolveNode",
"description": "Resolves _javascript_ node object for given node id.",
"parameters": [
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json (239182 => 239183)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-8.0.json 2018-12-13 23:20:35 UTC (rev 239183)
@@ -1272,11 +1272,6 @@
"description": "Unique DOM node identifier."
},
{
- "id": "BackendNodeId",
- "type": "integer",
- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
- },
- {
"id": "LiveRegionRelevant",
"type": "string",
"enum": ["additions", "removals", "text"],
@@ -1626,23 +1621,6 @@
"description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath"
},
{
- "name": "pushNodeByBackendIdToFrontend",
- "parameters": [
- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
- ],
- "returns": [
- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
- ],
- "description": "Requests that the node is sent to the caller given its backend node id."
- },
- {
- "name": "releaseBackendNodeIds",
- "parameters": [
- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." }
- ],
- "description": "Requests that group of <code>BackendNodeIds</code> is released."
- },
- {
"name": "resolveNode",
"parameters": [
{ "name": "nodeId", "$ref": "NodeId", "description": "Id of the node to resolve." },
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json (239182 => 239183)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.0.json 2018-12-13 23:20:35 UTC (rev 239183)
@@ -612,11 +612,6 @@
"description": "Unique DOM node identifier."
},
{
- "id": "BackendNodeId",
- "type": "integer",
- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
- },
- {
"id": "LiveRegionRelevant",
"type": "string",
"enum": ["additions", "removals", "text"],
@@ -975,23 +970,6 @@
"description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath"
},
{
- "name": "pushNodeByBackendIdToFrontend",
- "parameters": [
- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
- ],
- "returns": [
- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
- ],
- "description": "Requests that the node is sent to the caller given its backend node id."
- },
- {
- "name": "releaseBackendNodeIds",
- "parameters": [
- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." }
- ],
- "description": "Requests that group of <code>BackendNodeIds</code> is released."
- },
- {
"name": "resolveNode",
"parameters": [
{ "name": "nodeId", "$ref": "NodeId", "description": "Id of the node to resolve." },
Modified: trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json (239182 => 239183)
--- trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json 2018-12-13 23:17:44 UTC (rev 239182)
+++ trunk/Source/WebInspectorUI/Versions/Inspector-iOS-9.3.json 2018-12-13 23:20:35 UTC (rev 239183)
@@ -646,11 +646,6 @@
"description": "Unique DOM node identifier."
},
{
- "id": "BackendNodeId",
- "type": "integer",
- "description": "Unique DOM node identifier used to reference a node that may not have been pushed to the front-end."
- },
- {
"id": "PseudoType",
"type": "string",
"enum": ["before", "after"],
@@ -1017,23 +1012,6 @@
"description": "Requests that the node is sent to the caller given its path. // FIXME, use XPath"
},
{
- "name": "pushNodeByBackendIdToFrontend",
- "parameters": [
- { "name": "backendNodeId", "$ref": "BackendNodeId", "description": "The backend node id of the node." }
- ],
- "returns": [
- { "name": "nodeId", "$ref": "NodeId", "description": "The pushed node's id." }
- ],
- "description": "Requests that the node is sent to the caller given its backend node id."
- },
- {
- "name": "releaseBackendNodeIds",
- "parameters": [
- { "name": "nodeGroup", "type": "string", "description": "The backend node ids group name." }
- ],
- "description": "Requests that group of <code>BackendNodeIds</code> is released."
- },
- {
"name": "resolveNode",
"parameters": [
{ "name": "nodeId", "$ref": "NodeId", "description": "Id of the node to resolve." },
