Title: [239197] trunk/Source/WebKit
- Revision
- 239197
- Author
- [email protected]
- Date
- 2018-12-13 20:39:11 -0800 (Thu, 13 Dec 2018)
Log Message
[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
https://bugs.webkit.org/show_bug.cgi?id=192689
<rdar://problem/46323610>
Patch by Joseph Pecoraro <[email protected]> on 2018-12-13
Reviewed by Simon Fraser.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
* UIProcess/WebPageProxy.h:
Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable
which broadcasts it as a remote inspector target. Terminate this
as soon as the WebPageProxy closes and becomes invalid.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239196 => 239197)
--- trunk/Source/WebKit/ChangeLog 2018-12-14 04:09:59 UTC (rev 239196)
+++ trunk/Source/WebKit/ChangeLog 2018-12-14 04:39:11 UTC (rev 239197)
@@ -21,6 +21,12 @@
2018-12-13 Chris Dumez <[email protected]>
+ Unreviewed build fix for tvOS.
+
+ * Platform/cocoa/WKCrashReporter.mm:
+
+2018-12-13 Chris Dumez <[email protected]>
+
[PSON] We should not need to navigate to 'about:blank' to suspend pages
https://bugs.webkit.org/show_bug.cgi?id=192668
<rdar://problem/46701466>
Modified: trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm (239196 => 239197)
--- trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm 2018-12-14 04:09:59 UTC (rev 239196)
+++ trunk/Source/WebKit/Platform/cocoa/WKCrashReporter.mm 2018-12-14 04:39:11 UTC (rev 239197)
@@ -30,7 +30,7 @@
#import "CrashReporterClientSPI.h"
// Avoid having to link with libCrashReporterClient.a
-#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(TVOS) && __TV_OS_VERSION_MIN_REQUIRED >= 130000)
+#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000)
CRASH_REPORTER_CLIENT_HIDDEN
struct crashreporter_annotations_t gCRAnnotations
__attribute__((section("__DATA," CRASHREPORTER_ANNOTATIONS_SECTION)))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
