Title: [239216] tags/Safari-607.1.16.3/Source/WebKit
- Revision
- 239216
- Author
- kocsen_ch...@apple.com
- Date
- 2018-12-14 09:53:44 -0800 (Fri, 14 Dec 2018)
Log Message
Cherry-pick r239197. rdar://problem/46546071
[iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
https://bugs.webkit.org/show_bug.cgi?id=192689
<rdar://problem/46323610>
Patch by Joseph Pecoraro <pecor...@apple.com> on 2018-12-13
Reviewed by Simon Fraser.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
* UIProcess/WebPageProxy.h:
Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable
which broadcasts it as a remote inspector target. Terminate this
as soon as the WebPageProxy closes and becomes invalid.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: tags/Safari-607.1.16.3/Source/WebKit/ChangeLog (239215 => 239216)
--- tags/Safari-607.1.16.3/Source/WebKit/ChangeLog 2018-12-14 17:53:42 UTC (rev 239215)
+++ tags/Safari-607.1.16.3/Source/WebKit/ChangeLog 2018-12-14 17:53:44 UTC (rev 239216)
@@ -1,5 +1,31 @@
2018-12-14 Kocsen Chung <kocsen_ch...@apple.com>
+ Cherry-pick r239197. rdar://problem/46546071
+
+ [iOS] Web Inspector: Occasional UIProcess crashes under WebPageProxy::showInspectorIndication
+ https://bugs.webkit.org/show_bug.cgi?id=192689
+ <rdar://problem/46323610>
+
+ Patch by Joseph Pecoraro <pecor...@apple.com> on 2018-12-13
+ Reviewed by Simon Fraser.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::close):
+ * UIProcess/WebPageProxy.h:
+ Don't wait until ~WebPageProxy to destroy the WebPageProxyDebuggable
+ which broadcasts it as a remote inspector target. Terminate this
+ as soon as the WebPageProxy closes and becomes invalid.
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239197 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2018-12-13 Chris Dumez <cdu...@apple.com>
+
+ Unreviewed build fix for tvOS.
+
+ * Platform/cocoa/WKCrashReporter.mm:
+
+2018-12-14 Kocsen Chung <kocsen_ch...@apple.com>
+
Cherry-pick r239194. rdar://problem/46546071
Unreviewed build fix for tvOS.
Modified: tags/Safari-607.1.16.3/Source/WebKit/Platform/cocoa/WKCrashReporter.mm (239215 => 239216)
--- tags/Safari-607.1.16.3/Source/WebKit/Platform/cocoa/WKCrashReporter.mm 2018-12-14 17:53:42 UTC (rev 239215)
+++ tags/Safari-607.1.16.3/Source/WebKit/Platform/cocoa/WKCrashReporter.mm 2018-12-14 17:53:44 UTC (rev 239216)
@@ -30,7 +30,7 @@
#import "CrashReporterClientSPI.h"
// Avoid having to link with libCrashReporterClient.a
-#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(TVOS) && __TV_OS_VERSION_MIN_REQUIRED >= 130000)
+#if (PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 130000) || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 130000)
CRASH_REPORTER_CLIENT_HIDDEN
struct crashreporter_annotations_t gCRAnnotations
__attribute__((section("__DATA," CRASHREPORTER_ANNOTATIONS_SECTION)))
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
