Title: [239221] trunk/Source/WebKit
- Revision
- 239221
- Author
- [email protected]
- Date
- 2018-12-14 10:26:47 -0800 (Fri, 14 Dec 2018)
Log Message
Web Inspector: Prefer "about:blank" instead of an empty string for WebPageDebuggable url
https://bugs.webkit.org/show_bug.cgi?id=192691
<rdar://problem/46719798>
Patch by Joseph Pecoraro <[email protected]> on 2018-12-14
Reviewed by Darin Adler.
* UIProcess/WebPageDebuggable.cpp:
(WebKit::WebPageDebuggable::url const):
Instead of an empty string, return "about:blank" in bail cases.
When inspecting the page that matches the contents.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239220 => 239221)
--- trunk/Source/WebKit/ChangeLog 2018-12-14 18:24:21 UTC (rev 239220)
+++ trunk/Source/WebKit/ChangeLog 2018-12-14 18:26:47 UTC (rev 239221)
@@ -1,3 +1,16 @@
+2018-12-14 Joseph Pecoraro <[email protected]>
+
+ Web Inspector: Prefer "about:blank" instead of an empty string for WebPageDebuggable url
+ https://bugs.webkit.org/show_bug.cgi?id=192691
+ <rdar://problem/46719798>
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/WebPageDebuggable.cpp:
+ (WebKit::WebPageDebuggable::url const):
+ Instead of an empty string, return "about:blank" in bail cases.
+ When inspecting the page that matches the contents.
+
2018-12-14 Chris Dumez <[email protected]>
[PSON] Stop exposing PolicyAction::Suspend to WebCore
Modified: trunk/Source/WebKit/UIProcess/WebPageDebuggable.cpp (239220 => 239221)
--- trunk/Source/WebKit/UIProcess/WebPageDebuggable.cpp 2018-12-14 18:24:21 UTC (rev 239220)
+++ trunk/Source/WebKit/UIProcess/WebPageDebuggable.cpp 2018-12-14 18:26:47 UTC (rev 239221)
@@ -55,10 +55,13 @@
String WebPageDebuggable::url() const
{
if (!m_page.mainFrame())
- return String();
+ return "about:blank"_s;
String url = ""
- return url.isEmpty() ? "about:blank"_s : url;
+ if (url.isEmpty())
+ return "about:blank"_s;
+
+ return url;
}
bool WebPageDebuggable::hasLocalDebugger() const
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
