- Revision
- 239230
- Author
- ddkil...@apple.com
- Date
- 2018-12-14 13:12:23 -0800 (Fri, 14 Dec 2018)
Log Message
clang-tidy: Fix unnecessary object copies in WebCore/platform/graphics/avfoundation/objc/
<https://webkit.org/b/192708>
<rdar://problem/46735907>
Reviewed by Jer Noble.
* platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
(WebCore::toSample):
- Make argument a const reference.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- Update method signatures for implementation changes.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
- Make RetainPtr<> argument an rvalue reference and use WTFMove().
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
- Make RetainPtr<> argument a const reference.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVolume):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setMuted):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setPreservesPitch):
- Change for loop keys to be const references.
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- Update method signatures for implementation changes.
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(WebCore::SourceBufferPrivateAVFObjC::fastSeekTimeForMediaTime):
(WebCore::SourceBufferPrivateAVFObjC::seekToTime):
- Make Mediatime arguments a const reference.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239229 => 239230)
--- trunk/Source/WebCore/ChangeLog 2018-12-14 21:05:10 UTC (rev 239229)
+++ trunk/Source/WebCore/ChangeLog 2018-12-14 21:12:23 UTC (rev 239230)
@@ -1,3 +1,39 @@
+2018-12-14 David Kilzer <ddkil...@apple.com>
+
+ clang-tidy: Fix unnecessary object copies in WebCore/platform/graphics/avfoundation/objc/
+ <https://webkit.org/b/192708>
+ <rdar://problem/46735907>
+
+ Reviewed by Jer Noble.
+
+ * platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:
+ (WebCore::toSample):
+ - Make argument a const reference.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
+ - Update method signatures for implementation changes.
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::setAsset):
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
+ - Make RetainPtr<> argument an rvalue reference and use WTFMove().
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
+ - Make RetainPtr<> argument a const reference.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setVolume):
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setMuted):
+ (WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setPreservesPitch):
+ - Change for loop keys to be const references.
+
+ * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
+ - Update method signatures for implementation changes.
+ * platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
+ (WebCore::SourceBufferPrivateAVFObjC::fastSeekTimeForMediaTime):
+ (WebCore::SourceBufferPrivateAVFObjC::seekToTime):
+ - Make Mediatime arguments a const reference.
+
2018-12-14 Simon Fraser <simon.fra...@apple.com>
REGRESSION (r233268): contents of an animated element inside overflow:hidden disappear
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm (239229 => 239230)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm 2018-12-14 21:05:10 UTC (rev 239229)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm 2018-12-14 21:12:23 UTC (rev 239230)
@@ -300,7 +300,7 @@
bool m_hasAlpha { false };
};
-static ImageDecoderAVFObjCSample* toSample(PresentationOrderSampleMap::value_type pair)
+static ImageDecoderAVFObjCSample* toSample(const PresentationOrderSampleMap::value_type& pair)
{
return (ImageDecoderAVFObjCSample*)pair.second.get();
}
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h (239229 => 239230)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2018-12-14 21:05:10 UTC (rev 239229)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2018-12-14 21:12:23 UTC (rev 239230)
@@ -78,7 +78,7 @@
static void clearMediaCache(const String&, WallTime modifiedSince);
static void clearMediaCacheForOrigins(const String&, const HashSet<RefPtr<SecurityOrigin>>&);
- void setAsset(RetainPtr<id>);
+ void setAsset(RetainPtr<id>&&);
void tracksChanged() override;
#if HAVE(AVFOUNDATION_MEDIA_SELECTION_GROUP)
@@ -106,14 +106,14 @@
void playbackBufferEmptyDidChange(bool);
void playbackBufferFullWillChange();
void playbackBufferFullDidChange(bool);
- void loadedTimeRangesDidChange(RetainPtr<NSArray>);
- void seekableTimeRangesDidChange(RetainPtr<NSArray>);
- void tracksDidChange(RetainPtr<NSArray>);
+ void loadedTimeRangesDidChange(RetainPtr<NSArray>&&);
+ void seekableTimeRangesDidChange(RetainPtr<NSArray>&&);
+ void tracksDidChange(const RetainPtr<NSArray>&);
void hasEnabledAudioDidChange(bool);
void presentationSizeDidChange(FloatSize);
void durationDidChange(const MediaTime&);
void rateDidChange(double);
- void metadataDidArrive(RetainPtr<NSArray>, const MediaTime&);
+ void metadataDidArrive(const RetainPtr<NSArray>&, const MediaTime&);
void firstFrameAvailableDidChange(bool);
void trackEnabledDidChange(bool);
void canPlayFastReverseDidChange(bool);
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (239229 => 239230)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-12-14 21:05:10 UTC (rev 239229)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2018-12-14 21:12:23 UTC (rev 239230)
@@ -1530,9 +1530,9 @@
return m_cachedTotalBytes;
}
-void MediaPlayerPrivateAVFoundationObjC::setAsset(RetainPtr<id> asset)
+void MediaPlayerPrivateAVFoundationObjC::setAsset(RetainPtr<id>&& asset)
{
- m_avAsset = asset;
+ m_avAsset = WTFMove(asset);
}
MediaPlayerPrivateAVFoundation::AssetStatus MediaPlayerPrivateAVFoundationObjC::assetStatus() const
@@ -3051,17 +3051,17 @@
updateStates();
}
-void MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange(RetainPtr<NSArray> seekableRanges)
+void MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange(RetainPtr<NSArray>&& seekableRanges)
{
- m_cachedSeekableRanges = seekableRanges;
+ m_cachedSeekableRanges = WTFMove(seekableRanges);
seekableTimeRangesChanged();
updateStates();
}
-void MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange(RetainPtr<NSArray> loadedRanges)
+void MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange(RetainPtr<NSArray>&& loadedRanges)
{
- m_cachedLoadedRanges = loadedRanges;
+ m_cachedLoadedRanges = WTFMove(loadedRanges);
loadedTimeRangesChanged();
updateStates();
@@ -3123,7 +3123,7 @@
#endif
-void MediaPlayerPrivateAVFoundationObjC::metadataDidArrive(RetainPtr<NSArray> metadata, const MediaTime& mediaTime)
+void MediaPlayerPrivateAVFoundationObjC::metadataDidArrive(const RetainPtr<NSArray>& metadata, const MediaTime& mediaTime)
{
m_currentMetaData = metadata && ![metadata isKindOfClass:[NSNull class]] ? metadata : nil;
@@ -3165,7 +3165,7 @@
#endif
}
-void MediaPlayerPrivateAVFoundationObjC::tracksDidChange(RetainPtr<NSArray> tracks)
+void MediaPlayerPrivateAVFoundationObjC::tracksDidChange(const RetainPtr<NSArray>& tracks)
{
for (AVPlayerItemTrack *track in m_cachedTracks.get())
[track removeObserver:m_objcObserver.get() forKeyPath:@"enabled"];
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (239229 => 239230)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2018-12-14 21:05:10 UTC (rev 239229)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm 2018-12-14 21:12:23 UTC (rev 239230)
@@ -301,7 +301,7 @@
void MediaPlayerPrivateMediaSourceAVFObjC::setVolume(float volume)
{
- for (auto key : m_sampleBufferAudioRendererMap.keys())
+ for (const auto& key : m_sampleBufferAudioRendererMap.keys())
[(__bridge AVSampleBufferAudioRenderer *)key.get() setVolume:volume];
}
@@ -312,7 +312,7 @@
void MediaPlayerPrivateMediaSourceAVFObjC::setMuted(bool muted)
{
- for (auto key : m_sampleBufferAudioRendererMap.keys())
+ for (const auto& key : m_sampleBufferAudioRendererMap.keys())
[(__bridge AVSampleBufferAudioRenderer *)key.get() setMuted:muted];
}
@@ -460,7 +460,7 @@
void MediaPlayerPrivateMediaSourceAVFObjC::setPreservesPitch(bool preservesPitch)
{
NSString *algorithm = preservesPitch ? AVAudioTimePitchAlgorithmSpectral : AVAudioTimePitchAlgorithmVarispeed;
- for (auto key : m_sampleBufferAudioRendererMap.keys())
+ for (const auto& key : m_sampleBufferAudioRendererMap.keys())
[(__bridge AVSampleBufferAudioRenderer *)key.get() setAudioTimePitchAlgorithm:algorithm];
}
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h (239229 => 239230)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h 2018-12-14 21:05:10 UTC (rev 239229)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h 2018-12-14 21:12:23 UTC (rev 239230)
@@ -102,8 +102,8 @@
void trackDidChangeEnabled(AudioTrackPrivateMediaSourceAVFObjC*);
void willSeek();
- void seekToTime(MediaTime);
- MediaTime fastSeekTimeForMediaTime(MediaTime, MediaTime negativeThreshold, MediaTime positiveThreshold);
+ void seekToTime(const MediaTime&);
+ MediaTime fastSeekTimeForMediaTime(const MediaTime&, const MediaTime& negativeThreshold, const MediaTime& positiveThreshold);
FloatSize naturalSize();
int protectedTrackID() const { return m_protectedTrackID; }
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm (239229 => 239230)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2018-12-14 21:05:10 UTC (rev 239229)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm 2018-12-14 21:12:23 UTC (rev 239230)
@@ -1159,7 +1159,7 @@
m_mediaSource->sourceBufferPrivateDidChangeActiveState(this, isActive);
}
-MediaTime SourceBufferPrivateAVFObjC::fastSeekTimeForMediaTime(MediaTime time, MediaTime negativeThreshold, MediaTime positiveThreshold)
+MediaTime SourceBufferPrivateAVFObjC::fastSeekTimeForMediaTime(const MediaTime& time, const MediaTime& negativeThreshold, const MediaTime& positiveThreshold)
{
if (!m_client)
return time;
@@ -1171,7 +1171,7 @@
flush();
}
-void SourceBufferPrivateAVFObjC::seekToTime(MediaTime time)
+void SourceBufferPrivateAVFObjC::seekToTime(const MediaTime& time)
{
if (m_client)
m_client->sourceBufferPrivateSeekToTime(time);
