Title: [239240] trunk/Source/ThirdParty/libwebrtc
- Revision
- 239240
- Author
- you...@apple.com
- Date
- 2018-12-14 16:06:15 -0800 (Fri, 14 Dec 2018)
Log Message
kVTVideoEncoderSpecification_Usage should not be set if VCP is not enabled
https://bugs.webkit.org/show_bug.cgi?id=192716
Reviewed by Eric Carlson.
https://trac.webkit.org/changeset/239220 sets the usage value for all platforms, but we should only enable it for VCP.
* Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
Modified Paths
Diff
Modified: trunk/Source/ThirdParty/libwebrtc/ChangeLog (239239 => 239240)
--- trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-12-15 00:04:24 UTC (rev 239239)
+++ trunk/Source/ThirdParty/libwebrtc/ChangeLog 2018-12-15 00:06:15 UTC (rev 239240)
@@ -1,5 +1,16 @@
2018-12-14 Youenn Fablet <you...@apple.com>
+ kVTVideoEncoderSpecification_Usage should not be set if VCP is not enabled
+ https://bugs.webkit.org/show_bug.cgi?id=192716
+
+ Reviewed by Eric Carlson.
+
+ https://trac.webkit.org/changeset/239220 sets the usage value for all platforms, but we should only enable it for VCP.
+ * Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:
+ (-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
+
+2018-12-14 Youenn Fablet <you...@apple.com>
+
Set kVTVideoEncoderSpecification_Usage both when creating the compression session and once created
https://bugs.webkit.org/show_bug.cgi?id=192700
Modified: trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm (239239 => 239240)
--- trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm 2018-12-15 00:04:24 UTC (rev 239239)
+++ trunk/Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm 2018-12-15 00:06:15 UTC (rev 239240)
@@ -618,13 +618,13 @@
#endif
CFDictionarySetValue(encoderSpecs, kVTCompressionPropertyKey_RealTime, kCFBooleanTrue);
- if (auto key = getkVTVideoEncoderSpecification_Usage()) {
- int usageValue = 1;
- auto usage = CFNumberCreate(nullptr, kCFNumberIntType, &usageValue);
- CFDictionarySetValue(encoderSpecs, (__bridge CFStringRef)key, usage);
- CFRelease(usage);
- }
-
+#if ENABLE_VCP_ENCODER
+ auto key = getkVTVideoEncoderSpecification_Usage();
+ int usageValue = 1;
+ auto usage = CFNumberCreate(nullptr, kCFNumberIntType, &usageValue);
+ CFDictionarySetValue(encoderSpecs, (__bridge CFStringRef)key, usage);
+ CFRelease(usage);
+#endif
OSStatus status =
CompressionSessionCreate(nullptr, // use default allocator
_width,
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
