Title: [239323] trunk
- Revision
- 239323
- Author
- [email protected]
- Date
- 2018-12-17 22:37:28 -0800 (Mon, 17 Dec 2018)
Log Message
[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061
Reviewed by Dewei Zhu.
Source/WebKit:
Part 3.
Add some additional temporary logging info to determine if the timer is working as expected.
Once the bug is determined and fixed, we should remove all logging added in this patch.
* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::respondReceived):
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::timeOutTimerFired):
* UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:
(WebKit::MockAuthenticatorManager::respondReceivedInternal):
LayoutTests:
Add a time out value.
* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (239322 => 239323)
--- trunk/LayoutTests/ChangeLog 2018-12-18 06:33:58 UTC (rev 239322)
+++ trunk/LayoutTests/ChangeLog 2018-12-18 06:37:28 UTC (rev 239323)
@@ -1,3 +1,14 @@
+2018-12-17 Jiewen Tan <[email protected]>
+
+ [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=192061
+
+ Reviewed by Dewei Zhu.
+
+ Add a time out value.
+
+ * http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
+
2018-12-17 Eric Carlson <[email protected]>
[MediaStream] A stream's first video frame should be rendered
Modified: trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html (239322 => 239323)
--- trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html 2018-12-18 06:33:58 UTC (rev 239322)
+++ trunk/LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html 2018-12-18 06:37:28 UTC (rev 239323)
@@ -69,7 +69,8 @@
},
challenge: Base64URL.parse("MTIzNDU2"),
pubKeyCredParams: [{ type: "public-key", alg: -7 }],
- authenticatorSelection: { authenticatorAttachment: "cross-platform" }
+ authenticatorSelection: { authenticatorAttachment: "cross-platform" },
+ timeout: 10
}
};
Modified: trunk/Source/WebKit/ChangeLog (239322 => 239323)
--- trunk/Source/WebKit/ChangeLog 2018-12-18 06:33:58 UTC (rev 239322)
+++ trunk/Source/WebKit/ChangeLog 2018-12-18 06:37:28 UTC (rev 239323)
@@ -1,3 +1,22 @@
+2018-12-17 Jiewen Tan <[email protected]>
+
+ [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=192061
+
+ Reviewed by Dewei Zhu.
+
+ Part 3.
+
+ Add some additional temporary logging info to determine if the timer is working as expected.
+ Once the bug is determined and fixed, we should remove all logging added in this patch.
+
+ * UIProcess/WebAuthentication/AuthenticatorManager.cpp:
+ (WebKit::AuthenticatorManager::respondReceived):
+ (WebKit::AuthenticatorManager::initTimeOutTimer):
+ (WebKit::AuthenticatorManager::timeOutTimerFired):
+ * UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp:
+ (WebKit::MockAuthenticatorManager::respondReceivedInternal):
+
2018-12-17 Saam barati <[email protected]>
Enable HTTP and HTTPS proxies on iOS and make it a property of the NSURLSession
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp (239322 => 239323)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp 2018-12-18 06:33:58 UTC (rev 239322)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp 2018-12-18 06:37:28 UTC (rev 239323)
@@ -191,6 +191,8 @@
if (WTF::holds_alternative<PublicKeyCredentialData>(respond)) {
m_pendingCompletionHandler(WTFMove(respond));
clearStateAsync();
+ // FIXME(192061)
+ LOG_ERROR("Stop timer.");
m_requestTimeOutTimer.stop();
return;
}
@@ -223,11 +225,16 @@
using namespace AuthenticatorManagerInternal;
unsigned timeOutInMsValue = std::min(maxTimeOutValue, timeOutInMs.value_or(maxTimeOutValue));
+ // FIXME(192061)
+ LOG_ERROR("Start timer.");
m_requestTimeOutTimer.startOneShot(Seconds::fromMilliseconds(timeOutInMsValue));
}
void AuthenticatorManager::timeOutTimerFired()
{
+ ASSERT(m_requestTimeOutTimer.isActive());
+ // FIXME(192061)
+ LOG_ERROR("Timer fired.");
m_pendingCompletionHandler((ExceptionData { NotAllowedError, "Operation timed out."_s }));
clearStateAsync();
}
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp (239322 => 239323)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp 2018-12-18 06:33:58 UTC (rev 239322)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/Mock/MockAuthenticatorManager.cpp 2018-12-18 06:37:28 UTC (rev 239323)
@@ -47,6 +47,8 @@
pendingCompletionHandler()(WTFMove(respond));
clearStateAsync();
+ // FIXME(192061)
+ LOG_ERROR("Stop timer.");
requestTimeOutTimer().stop();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
