Title: [239352] trunk/Source
- Revision
- 239352
- Author
- [email protected]
- Date
- 2018-12-18 13:54:24 -0800 (Tue, 18 Dec 2018)
Log Message
clang-tidy: Use const reference for MediaTime parameter to prevent object copy
<https://webkit.org/b/192814>
Reviewed by Mark Lam.
Source/_javascript_Core:
* runtime/JSCJSValue.h:
(JSC::jsNumber):
Source/WebCore:
* bindings/js/JSDOMConvertNumbers.h:
(WebCore::JSConverter<IDLUnrestrictedDouble>::convert):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (239351 => 239352)
--- trunk/Source/_javascript_Core/ChangeLog 2018-12-18 21:51:56 UTC (rev 239351)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-12-18 21:54:24 UTC (rev 239352)
@@ -1,3 +1,13 @@
+2018-12-18 David Kilzer <[email protected]>
+
+ clang-tidy: Use const reference for MediaTime parameter to prevent object copy
+ <https://webkit.org/b/192814>
+
+ Reviewed by Mark Lam.
+
+ * runtime/JSCJSValue.h:
+ (JSC::jsNumber):
+
2018-12-18 Saam Barati <[email protected]>
Unreviewed. Appease a build error where we weren't using a variable defined in an "if"
Modified: trunk/Source/_javascript_Core/runtime/JSCJSValue.h (239351 => 239352)
--- trunk/Source/_javascript_Core/runtime/JSCJSValue.h 2018-12-18 21:51:56 UTC (rev 239351)
+++ trunk/Source/_javascript_Core/runtime/JSCJSValue.h 2018-12-18 21:54:24 UTC (rev 239352)
@@ -551,7 +551,7 @@
return JSValue(d);
}
-ALWAYS_INLINE JSValue jsNumber(MediaTime t)
+ALWAYS_INLINE JSValue jsNumber(const MediaTime& t)
{
return jsNumber(t.toDouble());
}
Modified: trunk/Source/WebCore/ChangeLog (239351 => 239352)
--- trunk/Source/WebCore/ChangeLog 2018-12-18 21:51:56 UTC (rev 239351)
+++ trunk/Source/WebCore/ChangeLog 2018-12-18 21:54:24 UTC (rev 239352)
@@ -1,3 +1,13 @@
+2018-12-18 David Kilzer <[email protected]>
+
+ clang-tidy: Use const reference for MediaTime parameter to prevent object copy
+ <https://webkit.org/b/192814>
+
+ Reviewed by Mark Lam.
+
+ * bindings/js/JSDOMConvertNumbers.h:
+ (WebCore::JSConverter<IDLUnrestrictedDouble>::convert):
+
2018-12-18 Justin Fan <[email protected]>
[WebGPU] BindGroupLayout and Device::createBindGroupLayout
Modified: trunk/Source/WebCore/bindings/js/JSDOMConvertNumbers.h (239351 => 239352)
--- trunk/Source/WebCore/bindings/js/JSDOMConvertNumbers.h 2018-12-18 21:51:56 UTC (rev 239351)
+++ trunk/Source/WebCore/bindings/js/JSDOMConvertNumbers.h 2018-12-18 21:54:24 UTC (rev 239352)
@@ -389,7 +389,7 @@
}
// Add overload for MediaTime.
- static JSC::JSValue convert(MediaTime value)
+ static JSC::JSValue convert(const MediaTime& value)
{
return JSC::jsNumber(JSC::purifyNaN(value.toDouble()));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
