Title: [239362] trunk/Source/WebKit
- Revision
- 239362
- Author
- [email protected]
- Date
- 2018-12-18 17:25:52 -0800 (Tue, 18 Dec 2018)
Log Message
[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061
Reviewed by Dewei Zhu.
Part 4.
Add some additional temporary logging info to determine if the time out value passed to the timer is right.
Once the bug is determined and fixed, we should remove all logging added in this patch.
* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::initTimeOutTimer):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239361 => 239362)
--- trunk/Source/WebKit/ChangeLog 2018-12-19 00:23:21 UTC (rev 239361)
+++ trunk/Source/WebKit/ChangeLog 2018-12-19 01:25:52 UTC (rev 239362)
@@ -1,3 +1,18 @@
+2018-12-18 Jiewen Tan <[email protected]>
+
+ [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=192061
+
+ Reviewed by Dewei Zhu.
+
+ Part 4.
+
+ Add some additional temporary logging info to determine if the time out value passed to the timer is right.
+ Once the bug is determined and fixed, we should remove all logging added in this patch.
+
+ * UIProcess/WebAuthentication/AuthenticatorManager.cpp:
+ (WebKit::AuthenticatorManager::initTimeOutTimer):
+
2018-12-18 Sihui Liu <[email protected]>
Clean up IndexedDB files between tests
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp (239361 => 239362)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp 2018-12-19 00:23:21 UTC (rev 239361)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp 2018-12-19 01:25:52 UTC (rev 239362)
@@ -226,7 +226,7 @@
unsigned timeOutInMsValue = std::min(maxTimeOutValue, timeOutInMs.value_or(maxTimeOutValue));
// FIXME(192061)
- LOG_ERROR("Start timer.");
+ LOG_ERROR("Start timer. %d", timeOutInMsValue);
m_requestTimeOutTimer.startOneShot(Seconds::fromMilliseconds(timeOutInMsValue));
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
