Title: [239370] trunk
- Revision
- 239370
- Author
- [email protected]
- Date
- 2018-12-18 22:37:46 -0800 (Tue, 18 Dec 2018)
Log Message
Error message for `-x ** y` contains a typo.
https://bugs.webkit.org/show_bug.cgi?id=192832
Reviewed by Saam Barati.
JSTests:
* ChakraCore/test/UnitTestFramework/UnitTestFramework.js:
(assert.assert.return.throws):
* stress/pow-expects-update-_expression_-on-lhs.js:
(throw.new.Error):
Update test expectations which match against the exact error message.
Source/_javascript_Core:
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseBinaryExpression):
Make corrections to error message: "amiguous" -> "ambiguous", "parenthesis" -> "parentheses"
Modified Paths
Diff
Modified: trunk/JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js (239369 => 239370)
--- trunk/JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js 2018-12-19 06:10:28 UTC (rev 239369)
+++ trunk/JSTests/ChakraCore/test/UnitTestFramework/UnitTestFramework.js 2018-12-19 06:37:46 UTC (rev 239370)
@@ -366,7 +366,7 @@
},
{
regexp: /Invalid unary operator on the left hand side of exponentiation \(\*\*\) operator/,
- replStr: "Unexpected token '**'. Amiguous unary _expression_ in the left hand side of the exponentiation _expression_; parenthesis must be used to disambiguate the _expression_."
+ replStr: "Unexpected token '**'. Ambiguous unary _expression_ in the left hand side of the exponentiation _expression_; parentheses must be used to disambiguate the _expression_."
},
{
regexp: /Assignment to read-only properties is not allowed in strict mode/,
Modified: trunk/JSTests/ChangeLog (239369 => 239370)
--- trunk/JSTests/ChangeLog 2018-12-19 06:10:28 UTC (rev 239369)
+++ trunk/JSTests/ChangeLog 2018-12-19 06:37:46 UTC (rev 239370)
@@ -1,3 +1,16 @@
+2018-12-18 Ross Kirsling <[email protected]>
+
+ Error message for `-x ** y` contains a typo.
+ https://bugs.webkit.org/show_bug.cgi?id=192832
+
+ Reviewed by Saam Barati.
+
+ * ChakraCore/test/UnitTestFramework/UnitTestFramework.js:
+ (assert.assert.return.throws):
+ * stress/pow-expects-update-_expression_-on-lhs.js:
+ (throw.new.Error):
+ Update test expectations which match against the exact error message.
+
2018-12-18 Mark Lam <[email protected]>
Gardening: test options fix.
Modified: trunk/JSTests/stress/pow-expects-update-_expression_-on-lhs.js (239369 => 239370)
--- trunk/JSTests/stress/pow-expects-update-_expression_-on-lhs.js 2018-12-19 06:10:28 UTC (rev 239369)
+++ trunk/JSTests/stress/pow-expects-update-_expression_-on-lhs.js 2018-12-19 06:37:46 UTC (rev 239370)
@@ -38,7 +38,7 @@
{
return ${token} a ** b;
}
- `, `SyntaxError: Unexpected token '**'. Amiguous unary _expression_ in the left hand side of the exponentiation _expression_; parenthesis must be used to disambiguate the _expression_.`);
+ `, `SyntaxError: Unexpected token '**'. Ambiguous unary _expression_ in the left hand side of the exponentiation _expression_; parentheses must be used to disambiguate the _expression_.`);
}
}
Modified: trunk/Source/_javascript_Core/ChangeLog (239369 => 239370)
--- trunk/Source/_javascript_Core/ChangeLog 2018-12-19 06:10:28 UTC (rev 239369)
+++ trunk/Source/_javascript_Core/ChangeLog 2018-12-19 06:37:46 UTC (rev 239370)
@@ -1,3 +1,14 @@
+2018-12-18 Ross Kirsling <[email protected]>
+
+ Error message for `-x ** y` contains a typo.
+ https://bugs.webkit.org/show_bug.cgi?id=192832
+
+ Reviewed by Saam Barati.
+
+ * parser/Parser.cpp:
+ (JSC::Parser<LexerType>::parseBinaryExpression):
+ Make corrections to error message: "amiguous" -> "ambiguous", "parenthesis" -> "parentheses"
+
2018-12-18 Saam Barati <[email protected]>
Update ARM64EHash
Modified: trunk/Source/_javascript_Core/parser/Parser.cpp (239369 => 239370)
--- trunk/Source/_javascript_Core/parser/Parser.cpp 2018-12-19 06:10:28 UTC (rev 239369)
+++ trunk/Source/_javascript_Core/parser/Parser.cpp 2018-12-19 06:37:46 UTC (rev 239370)
@@ -3886,7 +3886,7 @@
// Check this.
// If the binary operator <> has higher precedence than one of "**", this check does not work.
// But it's OK for ** because the operator "**" has the highest operator precedence in the binary operators.
- failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Amiguous unary _expression_ in the left hand side of the exponentiation _expression_; parenthesis must be used to disambiguate the _expression_");
+ failIfTrue(match(POW) && isUnaryOpExcludingUpdateOp(leadingTokenTypeForUnaryExpression), "Ambiguous unary _expression_ in the left hand side of the exponentiation _expression_; parentheses must be used to disambiguate the _expression_");
int precedence = isBinaryOperator(m_token.m_type);
if (!precedence)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
