Title: [239376] trunk/Source/WebCore
- Revision
- 239376
- Author
- [email protected]
- Date
- 2018-12-19 03:37:39 -0800 (Wed, 19 Dec 2018)
Log Message
[MSE] Remove unused method: stopAskingForMoreSamples()
https://bugs.webkit.org/show_bug.cgi?id=192754
Reviewed by Xabier Rodriguez-Calvar.
The stopAskingForMoreSamples() method from SourceBufferPrivate is not
being used by anyone. SourceBuffer is not calling it and no
SourceBufferPrivate is implementing it. Let's remove that noise.
* platform/graphics/SourceBufferPrivate.h:
(WebCore::SourceBufferPrivate::setActive):
(WebCore::SourceBufferPrivate::stopAskingForMoreSamples): Deleted.
* platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
(WebCore::SourceBufferPrivateGStreamer::stopAskingForMoreSamples): Deleted.
* platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239375 => 239376)
--- trunk/Source/WebCore/ChangeLog 2018-12-19 11:33:12 UTC (rev 239375)
+++ trunk/Source/WebCore/ChangeLog 2018-12-19 11:37:39 UTC (rev 239376)
@@ -1,5 +1,23 @@
2018-12-19 Alicia Boya García <[email protected]>
+ [MSE] Remove unused method: stopAskingForMoreSamples()
+ https://bugs.webkit.org/show_bug.cgi?id=192754
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ The stopAskingForMoreSamples() method from SourceBufferPrivate is not
+ being used by anyone. SourceBuffer is not calling it and no
+ SourceBufferPrivate is implementing it. Let's remove that noise.
+
+ * platform/graphics/SourceBufferPrivate.h:
+ (WebCore::SourceBufferPrivate::setActive):
+ (WebCore::SourceBufferPrivate::stopAskingForMoreSamples): Deleted.
+ * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:
+ (WebCore::SourceBufferPrivateGStreamer::stopAskingForMoreSamples): Deleted.
+ * platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
+
+2018-12-19 Alicia Boya García <[email protected]>
+
[MSE] Remove dead code: sourceBufferPrivateSeekToTime()
https://bugs.webkit.org/show_bug.cgi?id=192827
Modified: trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.h (239375 => 239376)
--- trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.h 2018-12-19 11:33:12 UTC (rev 239375)
+++ trunk/Source/WebCore/platform/graphics/SourceBufferPrivate.h 2018-12-19 11:37:39 UTC (rev 239376)
@@ -59,7 +59,6 @@
virtual void allSamplesInTrackEnqueued(const AtomicString&) { }
virtual bool isReadyForMoreSamples(const AtomicString&) { return false; }
virtual void setActive(bool) { }
- virtual void stopAskingForMoreSamples(const AtomicString&) { }
virtual void notifyClientWhenReadyForMoreSamples(const AtomicString&) { }
virtual Vector<String> enqueuedSamplesForTrackID(const AtomicString&) { return { }; }
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp (239375 => 239376)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp 2018-12-19 11:33:12 UTC (rev 239375)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp 2018-12-19 11:37:39 UTC (rev 239376)
@@ -148,11 +148,6 @@
m_mediaSource->sourceBufferPrivateDidChangeActiveState(this, isActive);
}
-void SourceBufferPrivateGStreamer::stopAskingForMoreSamples(const AtomicString&)
-{
- notImplemented();
-}
-
void SourceBufferPrivateGStreamer::notifyClientWhenReadyForMoreSamples(const AtomicString& trackId)
{
ASSERT(WTF::isMainThread());
Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h (239375 => 239376)
--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h 2018-12-19 11:33:12 UTC (rev 239375)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h 2018-12-19 11:37:39 UTC (rev 239376)
@@ -67,7 +67,6 @@
void allSamplesInTrackEnqueued(const AtomicString&) final;
bool isReadyForMoreSamples(const AtomicString&) final;
void setActive(bool) final;
- void stopAskingForMoreSamples(const AtomicString&) final;
void notifyClientWhenReadyForMoreSamples(const AtomicString&) final;
void setReadyForMoreSamples(bool);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
