Title: [239385] trunk/Source/WebInspectorUI
Revision
239385
Author
[email protected]
Date
2018-12-19 13:08:53 -0800 (Wed, 19 Dec 2018)

Log Message

Web Inspector: column sort controls in Layers tab sidebar don't render correctly in dark mode
https://bugs.webkit.org/show_bug.cgi?id=192845

Reviewed by Devin Rousso.

* UserInterface/Views/DataGrid.css:
(@media (prefers-dark-interface)):
(.data-grid th.sortable:active):
Drive-by: replace obnoxiously light background of the pressed header with a more subtle gray.

(.data-grid th.sort-ascending > div:first-child::after, .data-grid th.sort-descending > div:first-child::after):
Invert colors of the arrow glyph.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239384 => 239385)


--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-19 20:21:31 UTC (rev 239384)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-19 21:08:53 UTC (rev 239385)
@@ -1,3 +1,18 @@
+2018-12-19  Nikita Vasilyev  <[email protected]>
+
+        Web Inspector: column sort controls in Layers tab sidebar don't render correctly in dark mode
+        https://bugs.webkit.org/show_bug.cgi?id=192845
+
+        Reviewed by Devin Rousso.
+
+        * UserInterface/Views/DataGrid.css:
+        (@media (prefers-dark-interface)):
+        (.data-grid th.sortable:active):
+        Drive-by: replace obnoxiously light background of the pressed header with a more subtle gray.
+
+        (.data-grid th.sort-ascending > div:first-child::after, .data-grid th.sort-descending > div:first-child::after):
+        Invert colors of the arrow glyph.
+
 2018-12-18  Devin Rousso  <[email protected]>
 
         Web Inspector: Layers: increase default column width for other localizations

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css (239384 => 239385)


--- trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css	2018-12-19 20:21:31 UTC (rev 239384)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DataGrid.css	2018-12-19 21:08:53 UTC (rev 239385)
@@ -446,4 +446,13 @@
         color: var(--text-color-secondary);
         background-color: unset;
     }
+
+    .data-grid th.sortable:active {
+        background-color: hsl(0, 0%, 40%);
+    }
+
+    .data-grid th.sort-ascending > div:first-child::after,
+    .data-grid th.sort-descending > div:first-child::after {
+        filter: invert();
+    }
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to