Title: [239404] trunk/Source/WebInspectorUI
- Revision
- 239404
- Author
- [email protected]
- Date
- 2018-12-19 16:31:27 -0800 (Wed, 19 Dec 2018)
Log Message
Web Inspector: Audit: provide localization support for % pass display
https://bugs.webkit.org/show_bug.cgi?id=192870
<rdar://problem/46779245>
Reviewed by Brian Burg.
* UserInterface/Views/AuditTestGroupContentView.js:
(WI.AuditTestGroupContentView.prototype.initialLayout):
(WI.AuditTestGroupContentView.prototype.layout):
* UserInterface/Views/AuditTestGroupContentView.css:
(.content-view.audit-test-group > header > .percentage-pass):
(.content-view.audit-test-group > header > .percentage-pass > span): Added.
(@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass): Added.
(@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass > span): Added.
(.content-view.audit-test-group > header > .percentage-pass:not(:empty)::after): Deleted.
* Localizations/en.lproj/localizedStrings.js:
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (239403 => 239404)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-20 00:07:32 UTC (rev 239403)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-20 00:31:27 UTC (rev 239404)
@@ -1,3 +1,23 @@
+2018-12-19 Devin Rousso <[email protected]>
+
+ Web Inspector: Audit: provide localization support for % pass display
+ https://bugs.webkit.org/show_bug.cgi?id=192870
+ <rdar://problem/46779245>
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/AuditTestGroupContentView.js:
+ (WI.AuditTestGroupContentView.prototype.initialLayout):
+ (WI.AuditTestGroupContentView.prototype.layout):
+ * UserInterface/Views/AuditTestGroupContentView.css:
+ (.content-view.audit-test-group > header > .percentage-pass):
+ (.content-view.audit-test-group > header > .percentage-pass > span): Added.
+ (@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass): Added.
+ (@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass > span): Added.
+ (.content-view.audit-test-group > header > .percentage-pass:not(:empty)::after): Deleted.
+
+ * Localizations/en.lproj/localizedStrings.js:
+
2018-12-19 Nikita Vasilyev <[email protected]>
Web Inspector: Computed: make UI more usable when the panel is narrow
Modified: trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js (239403 => 239404)
--- trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2018-12-20 00:07:32 UTC (rev 239403)
+++ trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js 2018-12-20 00:31:27 UTC (rev 239404)
@@ -56,6 +56,7 @@
localizedStrings["%s delay"] = "%s delay";
localizedStrings["%s eval\n%s async"] = "%s eval\n%s async";
localizedStrings["%s interval"] = "%s interval";
+localizedStrings["%s%%"] = "%s%%";
localizedStrings["(Action %s)"] = "(Action %s)";
localizedStrings["(Disk)"] = "(Disk)";
localizedStrings["(Index)"] = "(Index)";
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css (239403 => 239404)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css 2018-12-20 00:07:32 UTC (rev 239403)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.css 2018-12-20 00:31:27 UTC (rev 239404)
@@ -122,16 +122,17 @@
.content-view.audit-test-group > header > .percentage-pass {
width: var(--metadata-width);
-webkit-margin-start: var(--audit-test-horizontal-space);
- font-size: 24px;
+ font-size: 16px;
text-align: center;
font-weight: bold;
- opacity: 0.65;
+ /* FIXME: Use CSS4 color blend functions once they're available. */
+ color: hsla(0, 0%, 0%, 0.5);
}
-.content-view.audit-test-group > header > .percentage-pass:not(:empty)::after {
- content: "%";
- font-size: 16px;
- opacity: 0.75;
+.content-view.audit-test-group > header > .percentage-pass > span {
+ font-size: 24px;
+ /* FIXME: Use CSS4 color blend functions once they're available. */
+ color: hsla(0, 0%, 0%, 0.65);
}
.content-view.audit-test-group > section > .audit-test-case:first-child,
@@ -143,3 +144,15 @@
.content-view.audit-test-group > section > .audit-test-case:last-child {
margin-bottom: var(--audit-test-vertical-space);
}
+
+@media (prefers-dark-interface) {
+ .content-view.audit-test-group > header > .percentage-pass {
+ /* FIXME: Use CSS4 color blend functions once they're available. */
+ color: hsla(0, 0%, 88%, 0.5);
+ }
+
+ .content-view.audit-test-group > header > .percentage-pass > span {
+ /* FIXME: Use CSS4 color blend functions once they're available. */
+ color: hsla(0, 0%, 88%, 0.65);
+ }
+}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js (239403 => 239404)
--- trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js 2018-12-20 00:07:32 UTC (rev 239403)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/AuditTestGroupContentView.js 2018-12-20 00:31:27 UTC (rev 239404)
@@ -59,9 +59,16 @@
this._levelNavigationBar.element.dataset.prefix = WI.UIString("Showing:");
this.headerView.addSubview(this._levelNavigationBar);
- this._percentageTextElement = this.headerView.element.appendChild(document.createElement("div"));
- this._percentageTextElement.classList.add("percentage-pass");
- this.headerView.element.appendChild(this._percentageTextElement);
+ this._percentageContainer = this.headerView.element.appendChild(document.createElement("div"));
+ this._percentageContainer.classList.add("percentage-pass");
+ this._percentageContainer.hidden = true;
+
+ this._percentageTextElement = document.createElement("span");
+
+ String.format(WI.UIString("%s%%"), [this._percentageTextElement], String.standardFormatters, this._percentageContainer, (a, b) => {
+ a.append(b);
+ return a;
+ });
}
layout()
@@ -78,6 +85,7 @@
this._levelScopeBar = null;
}
+ this._percentageContainer.hidden = true;
this._percentageTextElement.textContent = "";
if (this.representedObject.runningState === WI.AuditManager.RunningState.Inactive)
@@ -93,6 +101,7 @@
let levelCounts = result.levelCounts;
let totalCount = Object.values(levelCounts).reduce((accumulator, current) => accumulator + current);
this._percentageTextElement.textContent = Math.floor(100 * levelCounts[WI.AuditTestCaseResult.Level.Pass] / totalCount);
+ this._percentageContainer.hidden = false;
if (!this._levelScopeBar) {
let scopeBarItems = [];
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
