Title: [239414] trunk/Source/WebCore
- Revision
- 239414
- Author
- [email protected]
- Date
- 2018-12-19 17:28:06 -0800 (Wed, 19 Dec 2018)
Log Message
REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent
https://bugs.webkit.org/show_bug.cgi?id=188891
rdar://problem/42344352
Reviewed by Simon Fraser.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
Don't return early when m_layerForOverhangAreas is null to avoid skipping
setRootLayerConfigurationNeedsUpdate() and scheduleCompositingLayerUpdate().
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239413 => 239414)
--- trunk/Source/WebCore/ChangeLog 2018-12-20 01:22:39 UTC (rev 239413)
+++ trunk/Source/WebCore/ChangeLog 2018-12-20 01:28:06 UTC (rev 239414)
@@ -1,3 +1,16 @@
+2018-12-19 Timothy Hatcher <[email protected]>
+
+ REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent
+ https://bugs.webkit.org/show_bug.cgi?id=188891
+ rdar://problem/42344352
+
+ Reviewed by Simon Fraser.
+
+ * rendering/RenderLayerCompositor.cpp:
+ (WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
+ Don't return early when m_layerForOverhangAreas is null to avoid skipping
+ setRootLayerConfigurationNeedsUpdate() and scheduleCompositingLayerUpdate().
+
2018-12-19 Justin Fan <[email protected]>
[WebGPU] Add stubs for WebGPUPipelineLayout/Descriptor and device::createPipelineLayout
Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (239413 => 239414)
--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2018-12-20 01:22:39 UTC (rev 239413)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp 2018-12-20 01:28:06 UTC (rev 239414)
@@ -3280,13 +3280,12 @@
page().chrome().client().pageExtendedBackgroundColorDidChange(m_rootExtendedBackgroundColor);
#if ENABLE(RUBBER_BANDING)
- if (!m_layerForOverhangAreas)
- return;
-
- m_layerForOverhangAreas->setBackgroundColor(m_rootExtendedBackgroundColor);
-
- if (!m_rootExtendedBackgroundColor.isValid())
- m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang);
+ if (m_layerForOverhangAreas) {
+ m_layerForOverhangAreas->setBackgroundColor(m_rootExtendedBackgroundColor);
+
+ if (!m_rootExtendedBackgroundColor.isValid())
+ m_layerForOverhangAreas->setCustomAppearance(GraphicsLayer::CustomAppearance::ScrollingOverhang);
+ }
#endif
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
