Title: [239443] trunk/Source/WebInspectorUI
Revision
239443
Author
[email protected]
Date
2018-12-20 09:37:56 -0800 (Thu, 20 Dec 2018)

Log Message

Web Inspector: Dark Mode: unreadable background color for tables containing object previews
https://bugs.webkit.org/show_bug.cgi?id=192887
<rdar://problem/46855270>

Reviewed by Brian Burg.

* UserInterface/Views/LogContentView.css:
(.console-messages:focus .console-item .data-grid tr.selected td:not(:last-child)): Added.
(@media (prefers-dark-interface) .console-item .data-grid tr.selected): Added.
(@media (prefers-dark-interface) .console-messages:focus .console-item.selected .data-grid tr.selected): Added.
(@media (prefers-dark-interface) .console-messages:focus .console-item .data-grid tr.selected td:not(:last-child)): Added.

* UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
(.content-view.indexed-database-object-store > .data-grid tr.selected):
(.content-view.indexed-database-object-store > .data-grid:focus tr.selected): Added.
(@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid tr.selected): Added.
(@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid:focus tr.selected): Added.
(@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid:focus tr.selected td:not(:last-child)): Added.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (239442 => 239443)


--- trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 17:35:17 UTC (rev 239442)
+++ trunk/Source/WebInspectorUI/ChangeLog	2018-12-20 17:37:56 UTC (rev 239443)
@@ -1,3 +1,24 @@
+2018-12-20  Devin Rousso  <[email protected]>
+
+        Web Inspector: Dark Mode: unreadable background color for tables containing object previews
+        https://bugs.webkit.org/show_bug.cgi?id=192887
+        <rdar://problem/46855270>
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/LogContentView.css:
+        (.console-messages:focus .console-item .data-grid tr.selected td:not(:last-child)): Added.
+        (@media (prefers-dark-interface) .console-item .data-grid tr.selected): Added.
+        (@media (prefers-dark-interface) .console-messages:focus .console-item.selected .data-grid tr.selected): Added.
+        (@media (prefers-dark-interface) .console-messages:focus .console-item .data-grid tr.selected td:not(:last-child)): Added.
+
+        * UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
+        (.content-view.indexed-database-object-store > .data-grid tr.selected):
+        (.content-view.indexed-database-object-store > .data-grid:focus tr.selected): Added.
+        (@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid tr.selected): Added.
+        (@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid:focus tr.selected): Added.
+        (@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid:focus tr.selected td:not(:last-child)): Added.
+
 2018-12-19  Devin Rousso  <[email protected]>
 
         Web Inspector: Audit: fix descriptions for default tests

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.css (239442 => 239443)


--- trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.css	2018-12-20 17:35:17 UTC (rev 239442)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/IndexedDatabaseObjectStoreContentView.css	2018-12-20 17:37:56 UTC (rev 239443)
@@ -32,6 +32,10 @@
 }
 
 .content-view.indexed-database-object-store > .data-grid tr.selected {
+    background-color: hsl(210, 0%, 90%) !important;
+}
+
+.content-view.indexed-database-object-store > .data-grid:focus tr.selected {
     background-color: hsl(210, 90%, 90%) !important;
 }
 
@@ -43,3 +47,17 @@
  /* The line-height inside a data-grid is 17px instead of 13px, this will center vertically on the top line. */
     top: 2px;
 }
+
+@media (prefers-dark-interface) {
+    .content-view.indexed-database-object-store > .data-grid tr.selected {
+        background-color: hsl(210, 0%, 30%) !important;
+    }
+
+    .content-view.indexed-database-object-store > .data-grid:focus tr.selected {
+        background-color: hsl(210, 90%, 30%) !important;
+    }
+
+    .content-view.indexed-database-object-store > .data-grid:focus tr.selected td:not(:last-child) {
+        border-right-color: hsl(210, 70%, 25%);
+    }
+}

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css (239442 => 239443)


--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2018-12-20 17:35:17 UTC (rev 239442)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.css	2018-12-20 17:37:56 UTC (rev 239443)
@@ -134,6 +134,10 @@
     background-color: hsl(210, 0%, 90%) !important;
 }
 
+.console-messages:focus .console-item .data-grid tr.selected td:not(:last-child) {
+    border-right-color: hsl(210, 70%, 75%);
+}
+
 .console-messages:focus .console-item.selected {
     background-color: hsl(210, 98%, 96%);
     border-color: hsl(210, 90%, 93%);
@@ -259,6 +263,18 @@
         border-top-color: var(--console-message-separator);
     }
 
+    .console-item .data-grid tr.selected {
+        background-color: hsl(210, 0%, 35%) !important;
+    }
+
+    .console-messages:focus .console-item.selected .data-grid tr.selected {
+        background-color: hsl(210, 90%, 35%) !important;
+    }
+
+    .console-messages:focus .console-item .data-grid tr.selected td:not(:last-child) {
+        border-right-color: hsl(210, 70%, 25%);
+    }
+
     .console-messages {
         --background-color-selected: hsl(233, 30%, 30%);
         --border-color-selected: hsl(224, 30%, 35%);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to