Title: [239447] trunk/Source/WebCore
- Revision
- 239447
- Author
- [email protected]
- Date
- 2018-12-20 10:11:31 -0800 (Thu, 20 Dec 2018)
Log Message
Switch tabs before retuning PiP video to inline.
https://bugs.webkit.org/show_bug.cgi?id=192767
rdar://problem/46006046
Patch by Jeremy Jones <[email protected]> on 2018-12-20
Reviewed by Jer Noble.
No new tests because this code path only happens with a user action on system UI.
When exiting PiP, notify the fullscreen change observer so it can restore client UI state before exiting.
* platform/mac/VideoFullscreenInterfaceMac.mm:
(-[WebVideoFullscreenInterfaceMacObjC pipShouldClose:]):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (239446 => 239447)
--- trunk/Source/WebCore/ChangeLog 2018-12-20 18:08:14 UTC (rev 239446)
+++ trunk/Source/WebCore/ChangeLog 2018-12-20 18:11:31 UTC (rev 239447)
@@ -1,3 +1,18 @@
+2018-12-20 Jeremy Jones <[email protected]>
+
+ Switch tabs before retuning PiP video to inline.
+ https://bugs.webkit.org/show_bug.cgi?id=192767
+ rdar://problem/46006046
+
+ Reviewed by Jer Noble.
+
+ No new tests because this code path only happens with a user action on system UI.
+
+ When exiting PiP, notify the fullscreen change observer so it can restore client UI state before exiting.
+
+ * platform/mac/VideoFullscreenInterfaceMac.mm:
+ (-[WebVideoFullscreenInterfaceMacObjC pipShouldClose:]):
+
2018-12-19 Michael Catanzaro <[email protected]>
Unreviewed, fix GTK build after r239410
Modified: trunk/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm (239446 => 239447)
--- trunk/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm 2018-12-20 18:08:14 UTC (rev 239446)
+++ trunk/Source/WebCore/platform/mac/VideoFullscreenInterfaceMac.mm 2018-12-20 18:11:31 UTC (rev 239447)
@@ -272,8 +272,11 @@
{
ASSERT_UNUSED(pip, pip == _pipViewController);
- if (!_videoFullscreenInterfaceMac || !_videoFullscreenInterfaceMac->videoFullscreenChangeObserver())
+ if (!_videoFullscreenInterfaceMac)
return YES;
+
+ if (_videoFullscreenInterfaceMac->videoFullscreenChangeObserver())
+ _videoFullscreenInterfaceMac->videoFullscreenChangeObserver()->fullscreenMayReturnToInline();
_videoFullscreenInterfaceMac->requestHideAndExitPiP();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
