Title: [239451] trunk/Source
- Revision
- 239451
- Author
- [email protected]
- Date
- 2018-12-20 10:27:46 -0800 (Thu, 20 Dec 2018)
Log Message
WKWebView default UA doesn't freeze the build number
https://bugs.webkit.org/show_bug.cgi?id=192809
<rdar://problem/44687185>
Reviewed by Andy Estes.
Always reports the frozen build number.
Source/WebKit:
* UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(defaultApplicationNameForUserAgent): Do not expose the actual build number through this API.
Source/WebKitLegacy/mac:
* WebView/WebView.mm:
(-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
actual build number through this method call.
(-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239450 => 239451)
--- trunk/Source/WebKit/ChangeLog 2018-12-20 18:25:09 UTC (rev 239450)
+++ trunk/Source/WebKit/ChangeLog 2018-12-20 18:27:46 UTC (rev 239451)
@@ -1,3 +1,16 @@
+2018-12-20 Brent Fulgham <[email protected]>
+
+ WKWebView default UA doesn't freeze the build number
+ https://bugs.webkit.org/show_bug.cgi?id=192809
+ <rdar://problem/44687185>
+
+ Reviewed by Andy Estes.
+
+ Always reports the frozen build number.
+
+ * UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
+ (defaultApplicationNameForUserAgent): Do not expose the actual build number through this API.
+
2018-12-20 Jer Noble <[email protected]>
Enable MediaCapabilities by default.
Modified: trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm (239450 => 239451)
--- trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2018-12-20 18:25:09 UTC (rev 239450)
+++ trunk/Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm 2018-12-20 18:27:46 UTC (rev 239451)
@@ -456,7 +456,7 @@
static NSString *defaultApplicationNameForUserAgent()
{
#if PLATFORM(IOS_FAMILY)
- return [@"Mobile/" stringByAppendingString:[UIDevice currentDevice].buildVersion];
+ return @"Mobile/15E148";
#else
return nil;
#endif
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (239450 => 239451)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2018-12-20 18:25:09 UTC (rev 239450)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2018-12-20 18:27:46 UTC (rev 239451)
@@ -1,3 +1,18 @@
+2018-12-20 Brent Fulgham <[email protected]>
+
+ WKWebView default UA doesn't freeze the build number
+ https://bugs.webkit.org/show_bug.cgi?id=192809
+ <rdar://problem/44687185>
+
+ Reviewed by Andy Estes.
+
+ Always reports the frozen build number.
+
+ * WebView/WebView.mm:
+ (-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
+ actual build number through this method call.
+ (-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.
+
2018-12-19 Chris Dumez <[email protected]>
wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (239450 => 239451)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-12-20 18:25:09 UTC (rev 239450)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2018-12-20 18:27:46 UTC (rev 239451)
@@ -1158,12 +1158,15 @@
#if PLATFORM(IOS_FAMILY)
- (void)_setBrowserUserAgentProductVersion:(NSString *)productVersion buildVersion:(NSString *)buildVersion bundleVersion:(NSString *)bundleVersion
{
- [self setApplicationNameForUserAgent:[NSString stringWithFormat:@"Version/%@ Mobile/%@ Safari/%@", productVersion, buildVersion, bundleVersion]];
+ // The web-visible build and bundle versions are frozen to remove a fingerprinting surface
+ UNUSED_PARAM(buildVersion);
+ [self setApplicationNameForUserAgent:[NSString stringWithFormat:@"Version/%@ Mobile/15E148 Safari/%@", productVersion, bundleVersion]];
}
- (void)_setUIWebViewUserAgentWithBuildVersion:(NSString *)buildVersion
{
- [self setApplicationNameForUserAgent:[@"Mobile/" stringByAppendingString:buildVersion]];
+ UNUSED_PARAM(buildVersion);
+ [self setApplicationNameForUserAgent:@"Mobile/15E148"];
}
#endif // PLATFORM(IOS_FAMILY)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
