Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (239483 => 239484)
--- trunk/Source/WebInspectorUI/ChangeLog 2018-12-21 01:33:14 UTC (rev 239483)
+++ trunk/Source/WebInspectorUI/ChangeLog 2018-12-21 01:44:07 UTC (rev 239484)
@@ -1,5 +1,23 @@
2018-12-20 Nikita Vasilyev <[email protected]>
+ Web Inspector: Dark Mode: Type profiler popovers have black text on dark background
+ https://bugs.webkit.org/show_bug.cgi?id=192916
+ <rdar://problem/46863518>
+
+ Reviewed by Devin Rousso.
+
+ * UserInterface/Views/SourceCodeTextEditor.css:
+ (.popover .debugger-popover-content > .body):
+ * UserInterface/Views/TypeTreeElement.css:
+ (.item.type-tree-element.prototype):
+ (.item.type-tree-element.prototype:hover,):
+ * UserInterface/Views/TypeTreeView.css:
+ (.type-tree):
+ * UserInterface/Views/Variables.css:
+ (:root):
+
+2018-12-20 Nikita Vasilyev <[email protected]>
+
Web Inspector: Styles: Pressing Esc when editing name/value should select entire property
https://bugs.webkit.org/show_bug.cgi?id=192919
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css (239483 => 239484)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css 2018-12-21 01:33:14 UTC (rev 239483)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourceCodeTextEditor.css 2018-12-21 01:44:07 UTC (rev 239484)
@@ -144,7 +144,7 @@
}
.popover .debugger-popover-content > .body {
- border-top: 1px solid hsla(0, 0%, 0%, 0.3);
+ border-top: 1px solid var(--text-color-quaternary);
overflow: auto;
padding-top: 2px;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css (239483 => 239484)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css 2018-12-21 01:33:14 UTC (rev 239483)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeElement.css 2018-12-21 01:44:07 UTC (rev 239484)
@@ -74,8 +74,9 @@
.item.type-tree-element.prototype {
display: inline-block;
- border: 1px solid hsla(0, 0%, 0%, 0.06);
- background-color: hsla(0, 0%, 0%, 0.03);
+ /* Unusual order of values because of <webkit.org/b/192922>. */
+ border: hsla(0, 0%, var(--foreground-lightness), 0.06) solid 1px;
+ background-color: hsla(0, 0%, var(--foreground-lightness), 0.03);
border-radius: 3px;
padding-bottom: 1px;
@@ -98,7 +99,7 @@
.item.type-tree-element.prototype:hover,
.item.type-tree-element.prototype:focus {
- border-color: hsla(0, 0%, 0%, 0.1);
+ border-color: hsla(0, 0%, var(--foreground-lightness), 0.1);
}
.item.type-tree-element.prototype + ol {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css (239483 => 239484)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css 2018-12-21 01:33:14 UTC (rev 239483)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TypeTreeView.css 2018-12-21 01:44:07 UTC (rev 239484)
@@ -27,7 +27,7 @@
position: relative;
display: block;
- color: black;
+ color: var(--text-color);
font-family: -webkit-system-font, sans-serif;
font-size: 12px;
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css (239483 => 239484)
--- trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2018-12-21 01:33:14 UTC (rev 239483)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/Variables.css 2018-12-21 01:44:07 UTC (rev 239484)
@@ -37,6 +37,9 @@
--text-color: black;
--text-color-active: black;
+ /* Dividers, separators, background fills */
+ --text-color-quaternary: hsl(0, 0%, 85%);
+
--background-color: white;
--background-color-content: white;
