Title: [239486] trunk/Source/WebKit
- Revision
- 239486
- Author
- [email protected]
- Date
- 2018-12-20 18:17:19 -0800 (Thu, 20 Dec 2018)
Log Message
Remove unused NetworkProcessCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=192961
Reviewed by Andy Estes.
loadThrottleLatency isn't used since I replaced it with NetworkSessionCreationParameters.loadThrottleLatency in r238654
presentingApplicationPID has no effect because that value is only used in the WebProcess in NetworkExtensionContentFilter::initialize
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
* NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
* NetworkProcess/NetworkProcessCreationParameters.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureNetworkProcess):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239485 => 239486)
--- trunk/Source/WebKit/ChangeLog 2018-12-21 02:05:39 UTC (rev 239485)
+++ trunk/Source/WebKit/ChangeLog 2018-12-21 02:17:19 UTC (rev 239486)
@@ -1,3 +1,22 @@
+2018-12-20 Alex Christensen <[email protected]>
+
+ Remove unused NetworkProcessCreationParameters
+ https://bugs.webkit.org/show_bug.cgi?id=192961
+
+ Reviewed by Andy Estes.
+
+ loadThrottleLatency isn't used since I replaced it with NetworkSessionCreationParameters.loadThrottleLatency in r238654
+ presentingApplicationPID has no effect because that value is only used in the WebProcess in NetworkExtensionContentFilter::initialize
+
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::initializeNetworkProcess):
+ * NetworkProcess/NetworkProcessCreationParameters.cpp:
+ (WebKit::NetworkProcessCreationParameters::encode const):
+ (WebKit::NetworkProcessCreationParameters::decode):
+ * NetworkProcess/NetworkProcessCreationParameters.h:
+ * UIProcess/WebProcessPool.cpp:
+ (WebKit::WebProcessPool::ensureNetworkProcess):
+
2018-12-20 Chris Dumez <[email protected]>
Use Optional::hasValue() instead of Optional::has_value()
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (239485 => 239486)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2018-12-21 02:05:39 UTC (rev 239485)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2018-12-21 02:17:19 UTC (rev 239486)
@@ -275,7 +275,6 @@
WTF::setProcessPrivileges({ ProcessPrivilege::CanAccessRawCookies, ProcessPrivilege::CanAccessCredentials });
#endif
WebCore::NetworkStorageSession::permitProcessToUseCookieAPI(true);
- WebCore::setPresentingApplicationPID(parameters.presentingApplicationPID);
platformInitializeNetworkProcess(parameters);
WTF::Thread::setCurrentThreadIsUserInitiated();
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp (239485 => 239486)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp 2018-12-21 02:05:39 UTC (rev 239485)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.cpp 2018-12-21 02:17:19 UTC (rev 239486)
@@ -64,7 +64,6 @@
encoder << shouldSuppressMemoryPressureHandler;
encoder << shouldUseTestingNetworkSession;
encoder << urlSchemesRegisteredForCustomProtocols;
- encoder << presentingApplicationPID;
#if PLATFORM(COCOA)
encoder << uiProcessBundleIdentifier;
encoder << uiProcessSDKVersion;
@@ -170,8 +169,6 @@
return false;
if (!decoder.decode(result.urlSchemesRegisteredForCustomProtocols))
return false;
- if (!decoder.decode(result.presentingApplicationPID))
- return false;
#if PLATFORM(COCOA)
if (!decoder.decode(result.uiProcessBundleIdentifier))
return false;
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h (239485 => 239486)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h 2018-12-21 02:05:39 UTC (rev 239485)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcessCreationParameters.h 2018-12-21 02:17:19 UTC (rev 239486)
@@ -73,10 +73,8 @@
#endif
bool shouldSuppressMemoryPressureHandler { false };
bool shouldUseTestingNetworkSession { false };
- Seconds loadThrottleLatency;
Vector<String> urlSchemesRegisteredForCustomProtocols;
- ProcessID presentingApplicationPID { 0 };
#if PLATFORM(COCOA)
String uiProcessBundleIdentifier;
Modified: trunk/Source/WebKit/UIProcess/WebProcessPool.cpp (239485 => 239486)
--- trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-12-21 02:05:39 UTC (rev 239485)
+++ trunk/Source/WebKit/UIProcess/WebProcessPool.cpp 2018-12-21 02:17:19 UTC (rev 239486)
@@ -515,7 +515,6 @@
#endif
parameters.shouldUseTestingNetworkSession = m_shouldUseTestingNetworkSession;
- parameters.presentingApplicationPID = m_configuration->presentingApplicationPID();
parameters.urlSchemesRegisteredAsSecure = copyToVector(m_schemesToRegisterAsSecure);
parameters.urlSchemesRegisteredAsBypassingContentSecurityPolicy = copyToVector(m_schemesToRegisterAsBypassingContentSecurityPolicy);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
