Title: [239503] trunk
- Revision
- 239503
- Author
- [email protected]
- Date
- 2018-12-21 08:20:03 -0800 (Fri, 21 Dec 2018)
Log Message
Show punycode if URL contains Latin small letter dotless i
https://bugs.webkit.org/show_bug.cgi?id=192944
<rdar://problem/46103047>
Reviewed by Andy Estes.
Source/WTF:
Revise our "lookalike character" logic to include the small Latin
dotless i character.
Test: fast/url/host.html
* wtf/cocoa/NSURLExtras.mm:
(WTF::isLookalikeCharacter):
LayoutTests:
* fast/url/host-expected.txt:
* fast/url/host.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (239502 => 239503)
--- trunk/LayoutTests/ChangeLog 2018-12-21 12:29:57 UTC (rev 239502)
+++ trunk/LayoutTests/ChangeLog 2018-12-21 16:20:03 UTC (rev 239503)
@@ -1,3 +1,14 @@
+2018-12-20 Brent Fulgham <[email protected]>
+
+ Show punycode if URL contains Latin small letter dotless i
+ https://bugs.webkit.org/show_bug.cgi?id=192944
+ <rdar://problem/46103047>
+
+ Reviewed by Andy Estes.
+
+ * fast/url/host-expected.txt:
+ * fast/url/host.html:
+
2018-12-21 Carlos Garcia Campos <[email protected]>
Unreviewed GTK+ gardening. Remove platform specific files that are exactly the same as the generic expectation.
Modified: trunk/LayoutTests/fast/url/host-expected.txt (239502 => 239503)
--- trunk/LayoutTests/fast/url/host-expected.txt 2018-12-21 12:29:57 UTC (rev 239502)
+++ trunk/LayoutTests/fast/url/host-expected.txt 2018-12-21 16:20:03 UTC (rev 239503)
@@ -49,6 +49,8 @@
PASS canonicalize('http://quip−apple.com/') is 'http://xn--quipapple-tf4e.com/'
PASS canonicalize('http://iclouꝱ.com/') is 'http://xn--iclou-rl3s.com/'
PASS canonicalize('http://gọọgle.com/') is 'http://xn--ggle-gx5aa.com/'
+PASS canonicalize('http://ıcloud.com/') is 'http://xn--cloud-m4a.com/'
+PASS canonicalize('http://twıtter.com/') is 'http://xn--twtter-q9a.com/'
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/url/host.html (239502 => 239503)
--- trunk/LayoutTests/fast/url/host.html 2018-12-21 12:29:57 UTC (rev 239502)
+++ trunk/LayoutTests/fast/url/host.html 2018-12-21 16:20:03 UTC (rev 239503)
@@ -89,7 +89,9 @@
["quip\u2011apple.com", "xn--quipapple-y79d.com"],
["quip\u2212apple.com", "xn--quipapple-tf4e.com"],
["iclou\uA771.com", "xn--iclou-rl3s.com"],
- ["g\u1ECD\u1ECDgle.com", "xn--ggle-gx5aa.com"]
+ ["g\u1ECD\u1ECDgle.com", "xn--ggle-gx5aa.com"],
+ ["\u0131cloud.com", "xn--cloud-m4a.com"],
+ ["tw\u0131tter.com", "xn--twtter-q9a.com"]
];
for (var i = 0; i < cases.length; ++i) {
Modified: trunk/Source/WTF/ChangeLog (239502 => 239503)
--- trunk/Source/WTF/ChangeLog 2018-12-21 12:29:57 UTC (rev 239502)
+++ trunk/Source/WTF/ChangeLog 2018-12-21 16:20:03 UTC (rev 239503)
@@ -1,3 +1,19 @@
+2018-12-20 Brent Fulgham <[email protected]>
+
+ Show punycode if URL contains Latin small letter dotless i
+ https://bugs.webkit.org/show_bug.cgi?id=192944
+ <rdar://problem/46103047>
+
+ Reviewed by Andy Estes.
+
+ Revise our "lookalike character" logic to include the small Latin
+ dotless i character.
+
+ Test: fast/url/host.html
+
+ * wtf/cocoa/NSURLExtras.mm:
+ (WTF::isLookalikeCharacter):
+
2018-12-20 Chris Dumez <[email protected]>
Use Optional::hasValue() instead of Optional::has_value()
Modified: trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm (239502 => 239503)
--- trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm 2018-12-21 12:29:57 UTC (rev 239502)
+++ trunk/Source/WTF/wtf/cocoa/NSURLExtras.mm 2018-12-21 16:20:03 UTC (rev 239503)
@@ -115,6 +115,7 @@
case 0x00BD: /* VULGAR FRACTION ONE HALF */
case 0x00BE: /* VULGAR FRACTION THREE QUARTERS */
case 0x00ED: /* LATIN SMALL LETTER I WITH ACUTE */
+ case 0x0131: /* LATIN SMALL LETTER DOTLESS I */
case 0x01C3: /* LATIN LETTER RETROFLEX CLICK */
case 0x0251: /* LATIN SMALL LETTER ALPHA */
case 0x0261: /* LATIN SMALL LETTER SCRIPT G */
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
