Title: [239518] trunk/Source/WebKit
- Revision
- 239518
- Author
- [email protected]
- Date
- 2018-12-21 14:39:32 -0800 (Fri, 21 Dec 2018)
Log Message
[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061
Reviewed by Dewei Zhu.
Part 5.
Add some additional temporary logging info to determine if the time out value passed to the timer is respected.
Once the bug is determined and fixed, we should remove all logging added in this patch.
Reviewed by Dewei Zhu.
* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::timeOutTimerFired):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (239517 => 239518)
--- trunk/Source/WebKit/ChangeLog 2018-12-21 22:27:50 UTC (rev 239517)
+++ trunk/Source/WebKit/ChangeLog 2018-12-21 22:39:32 UTC (rev 239518)
@@ -1,3 +1,21 @@
+2018-12-21 Jiewen Tan <[email protected]>
+
+ [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=192061
+
+ Reviewed by Dewei Zhu.
+
+ Part 5.
+
+ Add some additional temporary logging info to determine if the time out value passed to the timer is respected.
+ Once the bug is determined and fixed, we should remove all logging added in this patch.
+
+ Reviewed by Dewei Zhu.
+
+ * UIProcess/WebAuthentication/AuthenticatorManager.cpp:
+ (WebKit::AuthenticatorManager::initTimeOutTimer):
+ (WebKit::AuthenticatorManager::timeOutTimerFired):
+
2018-12-21 Keith Rollin <[email protected]>
Crash in com.apple.WebKit: WebKit::WebResourceLoader::willSendRequest + 223
Modified: trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp (239517 => 239518)
--- trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp 2018-12-21 22:27:50 UTC (rev 239517)
+++ trunk/Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp 2018-12-21 22:39:32 UTC (rev 239518)
@@ -30,6 +30,7 @@
#include <WebCore/AuthenticatorTransport.h>
#include <WebCore/PublicKeyCredentialCreationOptions.h>
+#include <wtf/MonotonicTime.h>
namespace WebKit {
using namespace WebCore;
@@ -226,8 +227,9 @@
unsigned timeOutInMsValue = std::min(maxTimeOutValue, timeOutInMs.valueOr(maxTimeOutValue));
// FIXME(192061)
- LOG_ERROR("Start timer. %d", timeOutInMsValue);
+ LOG_ERROR("Start timer: %d. Current time: %f.", timeOutInMsValue, MonotonicTime::now().secondsSinceEpoch().value());
m_requestTimeOutTimer.startOneShot(Seconds::fromMilliseconds(timeOutInMsValue));
+ LOG_ERROR("Seconds until fire: %f", m_requestTimeOutTimer.secondsUntilFire().value());
}
void AuthenticatorManager::timeOutTimerFired()
@@ -234,7 +236,7 @@
{
ASSERT(m_requestTimeOutTimer.isActive());
// FIXME(192061)
- LOG_ERROR("Timer fired.");
+ LOG_ERROR("Timer fired: %f, Current time: %f", m_requestTimeOutTimer.secondsUntilFire().value(), MonotonicTime::now().secondsSinceEpoch().value());
m_pendingCompletionHandler((ExceptionData { NotAllowedError, "Operation timed out."_s }));
clearStateAsync();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
